Publish container image on release event

[kelson42]

By publishing 1.14.0 I saw that this workflow what not OK. I suspect we will have to release an 1.14.1 to get everything done properly.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.24%. Comparing base (363da15) to head (5b1fb7a).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2129      +/-   ##
==========================================
- Coverage   75.33%   75.24%   -0.10%     
==========================================
  Files          41       41              
  Lines        3207     3207              
  Branches      706      706              
==========================================
- Hits         2416     2413       -3     
- Misses        674      676       +2     
- Partials      117      118       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[audiodude]

Don't you still want the "on...push..." sections, because that's what publishes the :latest and :1.14 images?

[kelson42]

It didn't because I don't want to start tags with "v".

[benoit74]

Problem is simply that #1921 is incorrect / incomplete, you need to create a v1.14.0 tag, not a 1.14.0, it has been so since multiple releases:

I will fix this situation, no need for 1.14.1, code is not changing in main since yesterday.

[benoit74]

I've updated #1921 (comment) so that it is in-line with other scrapers practices and level of details

[benoit74]

This is done differently now, to be aligned with practices on other scrapers.

[kelson42]

@benoit74 I clearly didn't wanted to put at tag v... this is uselessly complicated and error prone. This rule to put a v before is just an heritage and IMHO should not be perpetuated. None of the softwares (maybe beside scrapers) uses this. What is the reason to put v...?