Speeds up dubbo tests, aligns conventions and bumps deps #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
| @@ -42,16 +41,17 @@ class TestServer { | |||
| if (linkLocalIp != null) { | |||
| // avoid dubbo's logic which might pick docker ip | |||
| System.setProperty(CommonConstants.DUBBO_IP_TO_BIND, linkLocalIp); | |||
| System.setProperty(Constants.DUBBO_IP_TO_REGISTRY, linkLocalIp); | |||
| System.setProperty(CommonConstants.DubboProperty.DUBBO_IP_TO_REGISTRY, linkLocalIp); | |||
There was a problem hiding this comment.
this was drift between beta 1 and 2
| } | ||
| // reduce dubbo shutdown timeout to 1s | ||
| System.setProperty(CommonConstants.SHUTDOWN_WAIT_KEY, "1000"); |
There was a problem hiding this comment.
this is why dubbo tests were so slow (still slow, but less slow)
reta
approved these changes
Apr 10, 2024
|
thanks for the look @reta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up dubbo tests by reducing the default server shutdown to 1s.
It also moves conventions for invoker tests to use "floor version" consistently per #1431.
Finally, this updates all the dependencies that can be updated.