tighten file system access entitlements #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scareything
commented
Oct 16, 2024
scareything
commented
- remove read-only access to the Downloads folder.
- change access to user-selected files from read/write to read-only.
| <key>com.apple.security.files.downloads.read-only</key> | ||
| <true/> | ||
| <key>com.apple.security.files.user-selected.read-write</key> | ||
| <key>com.apple.security.files.user-selected.read-only</key> |
There was a problem hiding this comment.
you need to be able to write the files, I think. Did you make sure you can successfully enroll a new identity?
There was a problem hiding this comment.
yes, enrollment still works. identity files are written into the app's sandbox container, which we have write access to without entitlements.
smilindave26
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.