Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add myself to robozome and reorder list to alphabetical order #18

Merged
merged 1 commit into from
Sep 7, 2022
Merged

feat: add myself to robozome and reorder list to alphabetical order #18

merged 1 commit into from
Sep 7, 2022

Conversation

mimotej
Copy link
Member

@mimotej mimotej commented Sep 7, 2022

  • Reordered list of owners to alphabetical order for better readability
  • Added myself as both approver and reviewer
  • removed @ tssala23 since he is not going to work on this project anymore

Part of #17

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2022
@mimotej
Copy link
Member Author

mimotej commented Sep 7, 2022

/cc @tumido

@sesheta sesheta requested a review from tumido September 7, 2022 12:08
@tssala23
Copy link
Member

tssala23 commented Sep 7, 2022

@mimotej Hello, I will still be working in Thai despite my internship finishing. Just had to get through the first week of classes and sort out my schedule.

tumido
tumido approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@sesheta
Copy link
Member

sesheta commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@tumido
Copy link
Member

tumido commented Sep 7, 2022

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@sesheta sesheta merged commit 3684141 into operate-first:main Sep 7, 2022
@tumido
Copy link
Member

tumido commented Sep 7, 2022

lol

@tumido
Copy link
Member

tumido commented Sep 7, 2022

@mimotej can you please reintroduce @tssala23 back again? Prow doesn't respect its own labels.. 😄

@mimotej
Copy link
Member Author

mimotej commented Sep 7, 2022

@mimotej can you please reintroduce @tssala23 back again? Prow doesn't respect its own labels.. smile

Will do 👍

@mimotej Hello, I will still be working in Thai despite my internship finishing. Just had to get through the first week of classes and sort out my schedule.

@tssala23 Ok, will reintroduce you again since prow is doing what it wants 😄

@mimotej mimotej mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

Assignees

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mimotej @tssala23 @sesheta @tumido