-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 WIP: Updating error message when no successors available #1083
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 72.74% 72.43% -0.31%
==========================================
Files 33 33
Lines 1948 1959 +11
==========================================
+ Hits 1417 1419 +2
- Misses 381 390 +9
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
internal/resolve/catalog.go
Outdated
@@ -101,6 +102,7 @@ func (r *CatalogResolver) Resolve(ctx context.Context, ext *ocv1alpha1.ClusterEx | |||
return nil | |||
} | |||
if compare.ByVersion(*resolvedBundle, thisBundle) < 0 { | |||
oldBundle = &thisBundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this approach covers all of the possibilities. I know the scenario talks about trying to "go backwards", but I think there's a similar scenario where the spec.version
is ahead of the installed bundle, but contains no successors.
In general, I think we need to find a way to distinguish between the following:
- No bundles match the package, channel, and version criteria
- Bundles do match, but none of them are successors of the currently installed bundle.
Distinguishing these may require more refactoring. Perhaps applying the various predicates separately would help us tell which predicates cause the resulting set of bundles to reduce to an empty list.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
This is an update to error messages received when trying to upgrade an operator, per #1022
Reviewer Checklist