Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 WIP: Updating error message when no successors available #1083

Closed
wants to merge 0 commits into from

Conversation

dhoover103
Copy link

Description

This is an update to error messages received when trying to upgrade an operator, per #1022

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2024
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit eacbc43
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e08524fd2c6b0008065b5e
😎 Deploy Preview https://deploy-preview-1083--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.43%. Comparing base (06b2455) to head (6962c0c).
Report is 38 commits behind head on main.

Files Patch % Lines
internal/resolve/catalog.go 60.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   72.74%   72.43%   -0.31%     
==========================================
  Files          33       33              
  Lines        1948     1959      +11     
==========================================
+ Hits         1417     1419       +2     
- Misses        381      390       +9     
  Partials      150      150              
Flag Coverage Δ
e2e 55.89% <35.00%> (-0.22%) ⬇️
unit 45.17% <60.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -101,6 +102,7 @@ func (r *CatalogResolver) Resolve(ctx context.Context, ext *ocv1alpha1.ClusterEx
return nil
}
if compare.ByVersion(*resolvedBundle, thisBundle) < 0 {
oldBundle = &thisBundle
Copy link
Member

@joelanford joelanford Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this approach covers all of the possibilities. I know the scenario talks about trying to "go backwards", but I think there's a similar scenario where the spec.version is ahead of the installed bundle, but contains no successors.

In general, I think we need to find a way to distinguish between the following:

  • No bundles match the package, channel, and version criteria
  • Bundles do match, but none of them are successors of the currently installed bundle.

Distinguishing these may require more refactoring. Perhaps applying the various predicates separately would help us tell which predicates cause the resulting set of bundles to reduce to an empty list.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants