Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 [Docs] Document tilt-support install #1236

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Sep 9, 2024

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@bentito bentito requested a review from a team as a code owner September 9, 2024 17:50
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a9583e1
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e033a72a05ae000882062d
😎 Deploy Preview https://deploy-preview-1236--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (f8c9077) to head (a9583e1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   76.53%   76.49%   -0.05%     
==========================================
  Files          40       40              
  Lines        2340     2340              
==========================================
- Hits         1791     1790       -1     
- Misses        392      393       +1     
  Partials      157      157              
Flag Coverage Δ
e2e 57.64% <ø> (ø)
unit 52.43% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tilt.md Outdated Show resolved Hide resolved
@LalatenduMohanty
Copy link
Member

Can we add a link of this document in https://github.com/operator-framework/operator-controller/blob/main/docs/drafts/developer.md? As both of these docs should be at least linked if not consolidated.

@bentito
Copy link
Contributor Author

bentito commented Sep 10, 2024

Can we add a link of this document in https://github.com/operator-framework/operator-controller/blob/main/docs/drafts/developer.md? As both of these docs should be at least linked if not consolidated.

I think the idea to simply merging this text about tilt into a section of the developer.md doc is a good one. I'd like to just finish up this PR so we have better text to merge. We can do the tilt -> developer merge in a follow up PR

@bentito
Copy link
Contributor Author

bentito commented Sep 10, 2024

Created this issue to track combining tilt.md into developer.md: #1242

@joelanford joelanford dismissed LalatenduMohanty’s stale review September 10, 2024 12:18

Requested changes were made

@joelanford joelanford added this pull request to the merge queue Sep 10, 2024
Merged via the queue into operator-framework:main with commit bb5eec5 Sep 10, 2024
16 of 17 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants