Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Catalogd upgrade-e2e fix #1667

Merged

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Jan 30, 2025

Description

Fix the catalogd run-latest-release make target running in the wrong directory.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@dtfranz dtfranz requested a review from a team as a code owner January 30, 2025 01:05
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 5c744d1
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/679ad051ea45b20008fc9dcf
😎 Deploy Preview https://deploy-preview-1667--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to unblock merge queue.

In a follow-up, we need to parameterize the default catalog URL and update the Makefile/goreleaser config to produce and publish the default catalog manifest.

@joelanford joelanford enabled auto-merge January 30, 2025 01:19
@joelanford joelanford added this pull request to the merge queue Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.40%. Comparing base (158d974) to head (5c744d1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   67.42%   67.40%   -0.03%     
==========================================
  Files          55       55              
  Lines        4632     4632              
==========================================
- Hits         3123     3122       -1     
- Misses       1284     1285       +1     
  Partials      225      225              
Flag Coverage Δ
e2e 53.29% <ø> (ø)
unit 54.42% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into operator-framework:main with commit 3de5c63 Jan 30, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants