-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Ensure catalog caches are valid after restart #1669
🐛 Ensure catalog caches are valid after restart #1669
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
99cb71a
to
54fed0f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1669 +/- ##
==========================================
- Coverage 67.42% 67.41% -0.01%
==========================================
Files 55 57 +2
Lines 4632 4619 -13
==========================================
- Hits 3123 3114 -9
+ Misses 1284 1278 -6
- Partials 225 227 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4f95510
to
75e06d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass looks good to me.
One more overall comment: we should put this same set of changes in operator-controller's main.go
and containers_image.go
files.
bc1db72
to
3f3a2e4
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
3f3a2e4
to
edba970
Compare
3998a3b
Description
This addresses an intermittent failure we've seen where operator-controller appears to not resolve catalogs that exist. We identified the issue coming from the catalog caches not being valid after a restart.
This PR adds two things to address this issue:
The PR also includes some small refactoring and fixes:
Reviewer Checklist