-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix install script and release to use and provide default-catalog #1675
🐛 fix install script and release to use and provide default-catalog #1675
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
94839e3
to
130cb8e
Compare
@@ -248,9 +248,10 @@ kind-load: $(KIND) #EXHELP Loads the currently constructed images into the KIND | |||
|
|||
.PHONY: kind-deploy | |||
kind-deploy: export MANIFEST := ./operator-controller.yaml | |||
kind-deploy: export DEFAULT_CATALOG := ./catalogd/config/base/default/clustercatalogs/default-catalogs.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I change this file, I want to test it out.
So, we cannot use the release one.
Otherwise, we would only get issues related to changes on this file after we do a release
@@ -329,9 +330,10 @@ release: $(GORELEASER) #EXHELP Runs goreleaser for the operator-controller. By d | |||
|
|||
.PHONY: quickstart | |||
quickstart: export MANIFEST := https://github.com/operator-framework/operator-controller/releases/download/$(VERSION)/operator-controller.yaml | |||
quickstart: export DEFAULT_CATALOG := "https://github.com/operator-framework/operator-controller/releases/download/$(VERSION)/default-catalogs.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to use the default catalog YAML released as part of the assets: See:
$ cat install.sh
#!/bin/bash
set -euo pipefail
IFS=$'\n\t'
olmv1_manifest=https://github.com/operator-framework/operator-controller/releases/download/v1.2.0-rc1-8-g130cb8e/operator-controller.yaml
if [[ -z "$olmv1_manifest" ]]; then
echo "Error: Missing required MANIFEST variable"
exit 1
fi
default_catalogs_manifest="https://github.com/operator-framework/operator-controller/releases/download/v1.2.0-rc1-8-g130cb8e/default-catalogs.yaml"
cert_mgr_version=v1.15.3
install_default_catalogs=true
@@ -124,6 +124,7 @@ release: | |||
disable: '{{ ne .Env.ENABLE_RELEASE_PIPELINE "true" }}' | |||
extra_files: | |||
- glob: 'operator-controller.yaml' | |||
- glob: './catalogd/config/base/default/clustercatalogs/default-catalogs.yaml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add the asset when we do a release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1675 +/- ##
=======================================
Coverage 67.39% 67.39%
=======================================
Files 57 57
Lines 4619 4619
=======================================
Hits 3113 3113
Misses 1279 1279
Partials 227 227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closes: #1674