Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix install script and release to use and provide default-catalog #1675

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jan 30, 2025

Closes: #1674

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner January 30, 2025 18:40
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 130cb8e
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/679bc7dd16efe3000850a75d
😎 Deploy Preview https://deploy-preview-1675--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camilamacedo86 camilamacedo86 force-pushed the fix-usage-default-catalog branch from 94839e3 to 130cb8e Compare January 30, 2025 18:41
@@ -248,9 +248,10 @@ kind-load: $(KIND) #EXHELP Loads the currently constructed images into the KIND

.PHONY: kind-deploy
kind-deploy: export MANIFEST := ./operator-controller.yaml
kind-deploy: export DEFAULT_CATALOG := ./catalogd/config/base/default/clustercatalogs/default-catalogs.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I change this file, I want to test it out.
So, we cannot use the release one.
Otherwise, we would only get issues related to changes on this file after we do a release

@@ -329,9 +330,10 @@ release: $(GORELEASER) #EXHELP Runs goreleaser for the operator-controller. By d

.PHONY: quickstart
quickstart: export MANIFEST := https://github.com/operator-framework/operator-controller/releases/download/$(VERSION)/operator-controller.yaml
quickstart: export DEFAULT_CATALOG := "https://github.com/operator-framework/operator-controller/releases/download/$(VERSION)/default-catalogs.yaml"
Copy link
Contributor Author

@camilamacedo86 camilamacedo86 Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use the default catalog YAML released as part of the assets: See:

 $ cat install.sh 
#!/bin/bash
set -euo pipefail
IFS=$'\n\t'

olmv1_manifest=https://github.com/operator-framework/operator-controller/releases/download/v1.2.0-rc1-8-g130cb8e/operator-controller.yaml

if [[ -z "$olmv1_manifest" ]]; then
    echo "Error: Missing required MANIFEST variable"
    exit 1
fi

default_catalogs_manifest="https://github.com/operator-framework/operator-controller/releases/download/v1.2.0-rc1-8-g130cb8e/default-catalogs.yaml"
cert_mgr_version=v1.15.3
install_default_catalogs=true

@@ -124,6 +124,7 @@ release:
disable: '{{ ne .Env.ENABLE_RELEASE_PIPELINE "true" }}'
extra_files:
- glob: 'operator-controller.yaml'
- glob: './catalogd/config/base/default/clustercatalogs/default-catalogs.yaml'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add the asset when we do a release

@joelanford joelanford enabled auto-merge January 30, 2025 18:54
@joelanford joelanford added this pull request to the merge queue Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (3998a3b) to head (130cb8e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1675   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files          57       57           
  Lines        4619     4619           
=======================================
  Hits         3113     3113           
  Misses       1279     1279           
  Partials      227      227           
Flag Coverage Δ
e2e 53.23% <ø> (-0.09%) ⬇️
unit 54.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into operator-framework:main with commit da0e803 Jan 30, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Released Install Script to use published yaml rather than local files
2 participants