🐛 (catalogd) Don't write to header after checking for Preconditions #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
anik120
force-pushed
the
metas-endpoint-checkprecondition-fix
branch
from
aab0229 to
6194070
Compare
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
- Coverage 67.66% 67.64% -0.03%
==========================================
Files 59 59
Lines 4991 4991
==========================================
- Hits 3377 3376 -1
- Misses 1367 1368 +1
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @anik120 is that rebased with main? |
`checkPreconditions` already writes http.StatusNotModified to the writer. It also writes http.StatusPreconditionFailed in certain cases. Writing again could overwrite the status written by `checkPreconditions`. This PR fixes the issue. Refers [the source](https://cs.opensource.google/go/go/+/master:src/net/http/fs.go;l=271-274) for correct usage. Signed-off-by: Anik Bhattacharjee <[email protected]>
anik120
force-pushed
the
metas-endpoint-checkprecondition-fix
branch
from
6194070 to
beb5f63
Compare
|
@camilamacedo86 rebased and pushed, let's see if that solves the problem |
camilamacedo86
approved these changes
Feb 5, 2025
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkPreconditionsalready writes http.StatusNotModified to the writer. It also writes http.StatusPreconditionFailed in certain cases. Writing again could overwrite the status written bycheckPreconditions. This PR fixes the issue.Refers the source for correct usage.
Additionally un-exports previously exported function/variable in the copied code from net/http.
Signed-off-by: Anik Bhattacharjee [email protected]
Description
Reviewer Checklist