Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 (catalogd) add more unit tests for localdir storage.Instance #1713

Merged

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Feb 5, 2025

Also rename query to metas in places that were missed by #1703

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120 anik120 requested a review from a team as a code owner February 5, 2025 20:08
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 45cdb37
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67a4d93b48f9130008bfe607
😎 Deploy Preview https://deploy-preview-1713--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.86%. Comparing base (dcf50b8) to head (45cdb37).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
catalogd/cmd/catalogd/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   67.66%   67.86%   +0.19%     
==========================================
  Files          59       59              
  Lines        4991     4994       +3     
==========================================
+ Hits         3377     3389      +12     
+ Misses       1367     1363       -4     
+ Partials      247      242       -5     
Flag Coverage Δ
e2e 53.00% <ø> (-0.38%) ⬇️
unit 55.08% <94.44%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anik120 anik120 changed the title (catalogd) add more unit tests for localdir storage.Instance 🌱 (catalogd) add more unit tests for localdir storage.Instance Feb 5, 2025
@anik120 anik120 force-pushed the catalogd-localdir-more-tests branch from 8fff885 to d9b915b Compare February 5, 2025 20:31
@anik120 anik120 force-pushed the catalogd-localdir-more-tests branch from 902f760 to 1d10495 Compare February 6, 2025 15:44
Also rename `query` to `metas` in places that were missed by operator-framework#1703

Signed-off-by: Anik Bhattacharjee <[email protected]>
@anik120 anik120 force-pushed the catalogd-localdir-more-tests branch from 1d10495 to 45cdb37 Compare February 6, 2025 15:46
@anik120 anik120 enabled auto-merge February 6, 2025 18:14
@anik120 anik120 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into operator-framework:main with commit 5965d5c Feb 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants