🌱 (catalogd) Validate catalogd api returns jsonl format, cleanup #1720
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
=======================================
Coverage 68.24% 68.24%
=======================================
Files 58 58
Lines 4988 4988
=======================================
Hits 3404 3404
Misses 1342 1342
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
azych
changed the title
azych
force-pushed
the
catalogd-api-misc-test
branch
from
aef513b to
6889bed
Compare
|
@anik120 I asked you and @grokspawn if you were going to work on this yesterday before picking it up to avoid situations where we duplicate work, but I guess it couldn't be helped ;) Feel free to include the rest of testing/rest of the changes from this PR in yours - I'll be (at least) removing the testing layer from here - no need to needlessly multiply and split work if it's already being done elsewhere. |
|
@azych apologies for the confusion. While that test is already in main at this point, the rest of the changes are still relevant though. I don't have any open PR at the moment, but I'm happy to help with this PR if needed. |
This adds additional unit test cases to make sure catalogd web api returns data in valid jsonl format both when serving via /all and /metas endpoints. Additionally, it: - removes unused suite_test.go and - fixes a typo in storage/http_preconditions_check.go
azych
force-pushed
the
catalogd-api-misc-test
branch
from
6889bed to
0f231f5
Compare
grokspawn
dismissed
anik120’s stale review
requested changes were made but user is on PTO for a week
This PR adds additional unit test cases to make sure catalogd web api returns data in valid jsonl format when serving via both /all and /metas endpoints.
Additionally, it:
Closes #1709
Description
Reviewer Checklist