-
Notifications
You must be signed in to change notification settings - Fork 66
✨ Implement Boxcutter #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thetechnick
wants to merge
27
commits into
operator-framework:main
Choose a base branch
from
thetechnick:poc-boxcutter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
✨ Implement Boxcutter #1946
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b833471
Update boxcutter library to branch with latest k8s and controller-run…
375c5e8
Update go.mod
f2d5a05
Add ClusterExtensionRevisionAPI
dc74df4
Add BoxcutterRuntime featuregate
8cd2d5d
Add Boxcutter applier
e0d74af
Add ClusterExtensionRevision controller
1acb117
Add Boxcutter runtime to main
51387e3
Remove ClusterExtensionRevision from crd-docs
695ebbf
Update hack/tools/update-crds.sh for ClusterExtensionRevision API
4f1d418
Generate manifests
dce88e7
Remove access manager and dynamic cache
46d1d6c
Update boxcutter to v0.3.0, add TrackingCache to Runnables
thetechnick f6f59dd
boxcutter webhook support
joelanford 4004ec5
add BoxcutterRuntime feature gate to experimental release
joelanford 6c94b91
add boxcutter cluster-admin cluster role binding in boxcutter's featu…
joelanford 2f0644e
Boxcutter Preflight
tmshort 64fa3eb
Boxcutter Preflight mock cleanup
tmshort 93b48c1
Use new TrackingCache Watch/Free.
thetechnick e13b2ad
add BoxcutterInstalledBundleGetter, plumb bundle metadata into revisi…
joelanford 3570ffb
InstalledBundleGetter -> RevisionStatesGetter
joelanford 6589521
refactor Applier interface and improve status reporting
joelanford d48ed62
fixup tests for applier and installedbundlegetter changes
joelanford a40ab9c
resolve linter issues
joelanford 4e241d0
set status for other failure modes during ClusterExtensionRevision re…
joelanford 685b5ec
TODO: fail upgrade-e2e if revision storage is unmigrated
joelanford f222b1b
fixing broken tests after rebase
joelanford 01cf0d3
Boxcutter Phases
dtfranz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
/* | ||
Copyright 2024. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package v1 | ||
|
||
import ( | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
"k8s.io/apimachinery/pkg/types" | ||
) | ||
|
||
const ClusterExtensionRevisionKind = "ClusterExtensionRevision" | ||
|
||
// ClusterExtensionRevisionSpec defines the desired state of ClusterExtensionRevision. | ||
type ClusterExtensionRevisionSpec struct { | ||
// Specifies the lifecycle state of the ClusterExtensionRevision. | ||
// +kubebuilder:default="Active" | ||
// +kubebuilder:validation:Enum=Active;Paused;Archived | ||
// +kubebuilder:validation:XValidation:rule="oldSelf == 'Active' || oldSelf == 'Paused' || oldSelf == 'Archived' && oldSelf == self", message="can not un-archive" | ||
LifecycleState ClusterExtensionRevisionLifecycleState `json:"lifecycleState,omitempty"` | ||
// +kubebuilder:validation:Required | ||
// +kubebuilder:validation:XValidation:rule="self == oldSelf", message="revision is immutable" | ||
Revision int64 `json:"revision"` | ||
// +kubebuilder:validation:Required | ||
// +kubebuilder:validation:XValidation:rule="self == oldSelf || oldSelf.size() == 0", message="phases is immutable" | ||
Phases []ClusterExtensionRevisionPhase `json:"phases"` | ||
// +kubebuilder:validation:XValidation:rule="self == oldSelf", message="previous is immutable" | ||
Previous []ClusterExtensionRevisionPrevious `json:"previous,omitempty"` | ||
} | ||
|
||
// ClusterExtensionRevisionLifecycleState specifies the lifecycle state of the ClusterExtensionRevision. | ||
type ClusterExtensionRevisionLifecycleState string | ||
|
||
const ( | ||
// ClusterExtensionRevisionLifecycleStateActive / "Active" is the default lifecycle state. | ||
ClusterExtensionRevisionLifecycleStateActive ClusterExtensionRevisionLifecycleState = "Active" | ||
// ClusterExtensionRevisionLifecycleStatePaused / "Paused" disables reconciliation of the ClusterExtensionRevision. | ||
// Only Status updates will still propagated, but object changes will not be reconciled. | ||
ClusterExtensionRevisionLifecycleStatePaused ClusterExtensionRevisionLifecycleState = "Paused" | ||
// ClusterExtensionRevisionLifecycleStateArchived / "Archived" disables reconciliation while also "scaling to zero", | ||
// which deletes all objects that are not excluded via the pausedFor property and | ||
// removes itself from the owner list of all other objects previously under management. | ||
ClusterExtensionRevisionLifecycleStateArchived ClusterExtensionRevisionLifecycleState = "Archived" | ||
) | ||
|
||
type ClusterExtensionRevisionPhase struct { | ||
Name string `json:"name"` | ||
Objects []ClusterExtensionRevisionObject `json:"objects"` | ||
Slices []string `json:"slices,omitempty"` | ||
} | ||
|
||
type ClusterExtensionRevisionObject struct { | ||
// +kubebuilder:validation:EmbeddedResource | ||
// +kubebuilder:pruning:PreserveUnknownFields | ||
Object unstructured.Unstructured `json:"object"` | ||
} | ||
|
||
type ClusterExtensionRevisionPrevious struct { | ||
// +kubebuilder:validation:Required | ||
Name string `json:"name"` | ||
// +kubebuilder:validation:Required | ||
UID types.UID `json:"uid"` | ||
} | ||
|
||
// ClusterExtensionRevisionStatus defines the observed state of a ClusterExtensionRevision. | ||
type ClusterExtensionRevisionStatus struct { | ||
// +patchMergeKey=type | ||
// +patchStrategy=merge | ||
// +listType=map | ||
// +listMapKey=type | ||
// +optional | ||
Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,1,rep,name=conditions"` | ||
} | ||
|
||
// +kubebuilder:object:root=true | ||
// +kubebuilder:resource:scope=Cluster | ||
// +kubebuilder:subresource:status | ||
|
||
// ClusterExtensionRevision is the Schema for the clusterextensionrevisions API | ||
type ClusterExtensionRevision struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
||
// spec is an optional field that defines the desired state of the ClusterExtension. | ||
// +optional | ||
Spec ClusterExtensionRevisionSpec `json:"spec,omitempty"` | ||
|
||
// status is an optional field that defines the observed state of the ClusterExtension. | ||
// +optional | ||
Status ClusterExtensionRevisionStatus `json:"status,omitempty"` | ||
} | ||
|
||
// +kubebuilder:object:root=true | ||
|
||
// ClusterExtensionRevisionList contains a list of ClusterExtensionRevision | ||
type ClusterExtensionRevisionList struct { | ||
metav1.TypeMeta `json:",inline"` | ||
|
||
// +optional | ||
metav1.ListMeta `json:"metadata,omitempty"` | ||
|
||
// items is a required list of ClusterExtensionRevision objects. | ||
// | ||
// +kubebuilder:validation:Required | ||
Items []ClusterExtensionRevision `json:"items"` | ||
} | ||
|
||
func init() { | ||
SchemeBuilder.Register(&ClusterExtensionRevision{}, &ClusterExtensionRevisionList{}) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.