Skip to content

Conversation

perdasilva
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2025
Copy link

openshift-ci bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thetechnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva perdasilva changed the title ✨ Add config support with jsonschema validation ✨ Add config support with jsonschema validation [WIP] Aug 29, 2025
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 0682c2d
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68b1bd039ce4b70008b0206f
😎 Deploy Preview https://deploy-preview-2177--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 83.62573% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.96%. Comparing base (97fabe5) to head (0682c2d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/operator-controller/rukpak/bundle/config.go 83.62% 18 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
+ Coverage   72.66%   72.96%   +0.29%     
==========================================
  Files          79       80       +1     
  Lines        7347     7549     +202     
==========================================
+ Hits         5339     5508     +169     
- Misses       1660     1684      +24     
- Partials      348      357       +9     
Flag Coverage Δ
e2e 43.08% <0.00%> (-1.24%) ⬇️
experimental-e2e 54.71% <0.00%> (-0.22%) ⬇️
unit 58.77% <83.62%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant