Skip to content

Conversation

pedjak
Copy link
Contributor

@pedjak pedjak commented Sep 22, 2025

Description

Given that at the creation we can create a revision with no phases, we should
declare .spec.phases as optional.

Added initial set of unit tests to assert CER .spec immutability.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Given that at the creation we can create a revision with no phases, we should
declare `.spec.phases` as optional.

Added initial set of unit tests to assert CER .spec immutability.
@pedjak pedjak requested a review from a team as a code owner September 22, 2025 15:22
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a77e58f
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68d1699d3a42900008d71d22
😎 Deploy Preview https://deploy-preview-2230--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pedjak pedjak changed the title 🌱 Make ClusterExtensionRevision .spec.phases optional 🌱 OPRUN-4138 Make ClusterExtensionRevision .spec.phases optional Sep 22, 2025
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.28%. Comparing base (33fdce2) to head (a77e58f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2230      +/-   ##
==========================================
+ Coverage   72.05%   72.28%   +0.23%     
==========================================
  Files          85       85              
  Lines        8405     8440      +35     
==========================================
+ Hits         6056     6101      +45     
+ Misses       1948     1939       -9     
+ Partials      401      400       -1     
Flag Coverage Δ
e2e 39.07% <ø> (-0.11%) ⬇️
experimental-e2e 46.30% <ø> (+0.22%) ⬆️
unit 57.15% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Sep 22, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
Copy link

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 16d1089 into operator-framework:main Sep 22, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants