Maintenance: make more settings runtime writable where possible #15754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machisuji
force-pushed
the
maintenance/make-more-settings-runtime-writable-where-possible
branch
3 times, most recently
from
d7ca1bb
to
d2048a8
Compare
the change of which was articifically limited to start-time only
machisuji
force-pushed
the
maintenance/make-more-settings-runtime-writable-where-possible
branch
from
d2048a8
to
b509dec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many places we use
OpenProject::Configurationinstead ofSettingwhere there is no need to do so. This only artificially limits the time these options can be changed. For all the calls in this PR it would make sense to allow changing them at runtime, too.This is mostly relevant in a setup where the environment variables cannot be changed globally, such as our cloud.
Uses in initializers are excluded from this change explicitly because most of the time these will not be changeable at runtime anyway.