Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ui-router from notifications #15840

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from
Draft

Remove ui-router from notifications #15840

wants to merge 16 commits into from

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Jun 13, 2024 •
edited
Loading

https://community.openproject.org/work_packages/55632

  • The sidebar component needs extensions

    • Notifications render icons
    • Notification count bubbles
    • Some of the options require an EE token, so we need to define an alternative link

  • Toolbar

  • Layout issues

    • The height of the page is currrently fixed to 100%, we need an alternative layout
    • Notification center has a split view that needs to be appended to the right side

  • Interactivity

    • Marking items as read needs to reload the sidebar (solved by frameElement.reload)

@oliverguenther oliverguenther force-pushed the impl/ui-router-notifications branch 3 times, most recently from f6e5208 to d3ebd6e Compare June 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Milestone
No milestone
1 participant
@oliverguenther