Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to render validation errors inside a dialog with a form #15948

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Document how to render validation errors inside a dialog with a form #15948

wants to merge 2 commits into from

Conversation

judithroth
Copy link
Contributor

No description provided.

@judithroth judithroth force-pushed the doc/dialog-with-form-validation-via-turbo branch 2 times, most recently from 00256a8 to ba324a1 Compare June 24, 2024 14:19
@judithroth judithroth changed the title Document how to render form validation errors inside a dialog with a form Document how to render validation errors inside a dialog with a form Jun 24, 2024
@judithroth judithroth force-pushed the doc/dialog-with-form-validation-via-turbo branch from ba324a1 to db179c4 Compare June 24, 2024 14:21
@judithroth judithroth force-pushed the doc/dialog-with-form-validation-via-turbo branch from db179c4 to f640e3a Compare June 24, 2024 14:25
@judithroth judithroth marked this pull request as ready for review June 24, 2024 14:31
HDinger
HDinger reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @judithroth

Looks good, short and on point 👍 I am wondering whether we want to show the code of ComponentThatRendersAForm as well to highlight that the Dialog::Body and Dialog::Footer components shall be used. Wdyt?

@judithroth
Copy link
Contributor Author

Hi @judithroth

Looks good, short and on point 👍 I am wondering whether we want to show the code of ComponentThatRendersAForm as well to highlight that the Dialog::Body and Dialog::Footer components shall be used. Wdyt?

Usually I would like that idea very much 👍
It's hard to see in the PR diff, but actually the ComponentThatRendersAForm is from the paragraph above the new one I added. There it's used in a Dialog. So when reading the documentation top to button it would repeat - but it could be worth it for people skipping directly to this part 🤔 I will add to the text that this refers to the example above. Then it's clear and there is no duplication.

@judithroth judithroth requested a review from HDinger June 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apfohl apfohl Awaiting requested review from apfohl

@HDinger HDinger Awaiting requested review from HDinger

Assignees
No one assigned
Labels
needs review
Milestone
No milestone
2 participants
@judithroth @HDinger