Skip to content

[#767] iOS 17에서 스크롤을 해도 NavigationTitle이 large로 고정되는 현상을 해결한다 #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opficdev merged 2 commits into from
Jul 28, 2026
Merged

[#767] iOS 17에서 스크롤을 해도 NavigationTitle이 large로 고정되는 현상을 해결한다 #774

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8586ed
fix: 푸시 알림 헤더 가로 스크롤 제거
opficdev Jul 28, 2026
150ae5a
docs: PR 및 리뷰 한국어 작성 지침 추가
opficdev Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 57 additions & 60 deletions ...tion/Presentation/NotificationTab/Sources/PushNotification/PushNotificationListView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,81 +157,78 @@ public struct PushNotificationListView: View {
}

private var headerView: some View {
ScrollView(.horizontal) {
HStack(spacing: 8) {
if 0 < store.appliedFilterCount {
Menu {
Text(
String.localizedStringWithFormat(
String(localized: "push_filters_applied_format"),
Int64(store.appliedFilterCount)
)
)
Button(role: .destructive) {
store.send(.view(.resetFilters))
} label: {
Text(String(localized: "push_clear_all_filters"))
}
} label: {
HStack(spacing: 6) {
Image(systemName: "line.3.horizontal.decrease")
filterBadge
}
.adaptiveButtonStyle()
}
}

Button {
DispatchQueue.main.async {
store.send(.view(.toggleSortOption))
}
} label: {
let condition = store.query.sortOrder == .oldest
HStack(spacing: 8) {
Comment thread
opficdev marked this conversation as resolved.
if 0 < store.appliedFilterCount {
Menu {
Text(
String.localizedStringWithFormat(
String(localized: "push_sort_format"),
store.query.sortOrder.title
String(localized: "push_filters_applied_format"),
Int64(store.appliedFilterCount)
)
)
.foregroundStyle(condition ? .white : Color(.label))
.adaptiveButtonStyle(color: condition ? .blue : .clear)
}
.frame(height: headerHeight)

Menu {
Picker(selection: $store.query.timeFilter) {
ForEach(PushNotificationQuery.TimeFilter.availableOptions, id: \.self) { option in
Text(option.title).tag(option)
}
Button(role: .destructive) {
store.send(.view(.resetFilters))
} label: {
Text(String(localized: "push_period"))
Text(String(localized: "push_clear_all_filters"))
}
} label: {
let condition = store.query.timeFilter == .none
HStack {
Text(String(localized: "push_period"))
Image(systemName: "chevron.down")
HStack(spacing: 6) {
Image(systemName: "line.3.horizontal.decrease")
filterBadge
}
.foregroundStyle(condition ? Color(.label) : .white)
.adaptiveButtonStyle(color: condition ? .clear : .blue)
.adaptiveButtonStyle()
}
}

Button {
DispatchQueue.main.async {
store.send(.view(.toggleSortOption))
}
} label: {
let condition = store.query.sortOrder == .oldest
Text(
String.localizedStringWithFormat(
String(localized: "push_sort_format"),
store.query.sortOrder.title
)
)
.foregroundStyle(condition ? .white : Color(.label))
.adaptiveButtonStyle(color: condition ? .blue : .clear)
}
.frame(height: headerHeight)

Button {
DispatchQueue.main.async {
store.send(.view(.toggleUnreadOnly))
Menu {
Picker(selection: $store.query.timeFilter) {
ForEach(PushNotificationQuery.TimeFilter.availableOptions, id: \.self) { option in
Text(option.title).tag(option)
}
} label: {
let condition = store.query.unreadOnly
Text(String(localized: "push_unread"))
.foregroundStyle(condition ? .white : Color(.label))
.adaptiveButtonStyle(color: condition ? .blue : .clear)
Text(String(localized: "push_period"))
}
} label: {
let condition = store.query.timeFilter == .none
HStack {
Text(String(localized: "push_period"))
Image(systemName: "chevron.down")
}
.frame(height: headerHeight)
.foregroundStyle(condition ? Color(.label) : .white)
.adaptiveButtonStyle(color: condition ? .clear : .blue)
}

Button {
DispatchQueue.main.async {
store.send(.view(.toggleUnreadOnly))
}
} label: {
let condition = store.query.unreadOnly
Text(String(localized: "push_unread"))
.foregroundStyle(condition ? .white : Color(.label))
.adaptiveButtonStyle(color: condition ? .blue : .clear)
}
.frame(height: headerHeight)
}
.scrollIndicators(.never)
.scrollDisabled(!isScrollTrackingEnabled)
.contentMargins(.leading, 16, for: .scrollContent)
.padding(.leading, 16)
.frame(maxWidth: .infinity, alignment: .leading)
.frame(height: headerHeight)
.onAppear {
headerOffset = 0
Expand Down
Loading