firmware: ability to shutdown after upgrade

[sopex]

Important notices

Before you submit a pull request, we ask you kindly to acknowledge the following:

• I have read the contributing guidelines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I opened an issue first for non-trivial changes and linked it below.
• AI tools were used to create at least part of the code submitted herewith.

Details

This PR uses the dialog box that lets a user know that the upgrade will initiate a restart, to present the user with the ability to power off instead. If no choice is made after 30 seconds, it automatically restarts.

Maybe the countdown should be removed and just wait for an answer, but it seems like ample time, and the dialog box shows up immediately after a user action, so no chance to be forgotten.

---

Related issue

Closes: #10245

[fichtner]

I was thinking something similar but without a persistent option using a checkbox in the reboot dialog. Probably going to write this from scratch while testing which is in this case easier than doing review cycles.

[sopex]

I was thinking something similar but without a persistent option using a checkbox in the reboot dialog. Probably going to write this from scratch while testing which is in this case easier than doing review cycles.

Sure, rewrite it but this is not persistent and in the dialog box :)
Review, what is that? My code needs review? :)
In all seriousness, this works as is. I did multiple updates and worked as expected.

[fichtner]

well it is persistent: <shutdown type="BooleanField"/>

it would be more flexible to have this as an optional parameter for update/upgrade actions so it can be used for API-based maintenance too

[sopex]

well it is persistent: <shutdown type="BooleanField"/>

it would be more flexible to have this as an optional parameter for update/upgrade actions so it can be used for API-based maintenance too

Yeah ok. It flips back immediately after being used. It's a persistent variable, not a persistent option.

[fichtner]

As a general note the Power menu has "Power Off" and we should follow that terminology.

[sopex]

As a general note the Power menu has "Power Off" and we should follow that terminology.

It seemed to me that only user facing power off is used, so I just did the things the user sees and kept shutdown for the variables.