Captive Portal: re-introduce hash lookup for accounting purposes#10275
Open
Captive Portal: re-introduce hash lookup for accounting purposes#10275
Conversation
Table redirection allowed for constant time lookups, with the migration to pf this was changed to a linear time lookup. While here, fix a small edge case that kills states for ips flipping primary IPs according to hostwatch. Also make sure to include the set of ipfw keys to "registered addresses" to make sure theyre properly cleaned up from the table
fichtner
reviewed
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Table redirection allowed for constant time lookups, with the migration to pf this was changed to a linear time lookup.
While here, fix a small edge case that kills states for ips flipping primary IPs according to hostwatch. Also make sure to include the set of ipfw keys to "registered addresses" to make sure theyre properly cleaned up from the table
Describe the proposed solution
Reuse table lookups.
The
add_accountinglogic now expects the full set of IP addresses associated with a single client to make sure they use the same rulenumber, this allows us to prevent wasting space in the ruleset.del_accountingis unaffected.Related issue
#9355