Services: Kea DHCPv4/6: Build reservation status from control socket output, so it matches the scope of individual subnet#10276
Merged
Conversation
Monviech
changed the title
fichtner
approved these changes
May 8, 2026
Member
fichtner
left a comment
fichtner
left a comment
There was a problem hiding this comment.
if it works fine. Less controller fiddling is good.
…output, so it matches the scope of individual subnets as well. Add client-id since it's relevant for IPv4 leases as well in default configuration. We return an array now, change frontend detection if it's dynamic or static lease Missed a closing bracket Typo in client_id Remove unused imports in LeasesController Add comment to build_reserved_matches() to explain why the subnet-id logic exists now
Monviech
force-pushed
the
kea-here-we-lease-again
branch
from
85af173 to
180fcb4
Compare
Member
Author
|
Tested by me and @dseven and stuff is working as expected now. |
Closed
2 tasks
fichtner
pushed a commit
that referenced
this pull request
May 11, 2026
…output, so it matches the scope of individual subnet (#10276) * Services: Kea DHCPv4/6: Build reservation status from control socket output, so it matches the scope of individual subnets as well. Add client-id since it's relevant for IPv4 leases as well in default configuration. We return an array now, change frontend detection if it's dynamic or static lease Missed a closing bracket Typo in client_id Remove unused imports in LeasesController Add comment to build_reserved_matches() to explain why the subnet-id logic exists now * Add state as well, helpful for troubleshooting * Add a state formatter to convert number status into their documented meaning * Some data-width micro management (cherry picked from commit 9b93f84)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Problem described in issue.
Describe the proposed solution
Solution is to use the API to build all lease and reservation related concerns. With this change it will finally be "perfect".
Related issue
#10274