Docs/clarify static lease register #8028
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Oct 30, 2024
| @@ -63,6 +63,7 @@ | |||
| <type>checkbox</type> | |||
| <help> | |||
| <
There was a problem hiding this comment.
Static mappings are not leases. IP addresses are more or less implied for DNS to resolve but clarifying it in the first sentence wouldn’t hurt I suppose for all those who do read…
There was a problem hiding this comment.
Does DHCP static mapping which doesn't contain a static ip will not be registered sound more accurate ?
There was a problem hiding this comment.
You want to make it affirmative:
… static mappings with an IP address will be registered…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some documentation to clarify #7990
I could not run the test on my computer, the makefile being for BSD system.
I'm hopping for an internal CI on your side ?