dashboard: add Notepad widget

[sopex]

Closes: #9728

If anyone wants to test it :)

[Monviech]

It is helpful and admirable that you want to work on so many things.
But please slow down a bit, if somebody has something assigned it would be courteous to ask first in the issue what the strategy is.

[sopex]

It is helpful and admirable that you want to work on so many things. But please slow down a bit, if somebody has something assigned it would be courteous to ask first in the issue what the strategy is.

Under no circumstances should you take my commits as a pressure to act on them. I understand you have your own, much more logical priorities. If there is a similar issue/ request I just open a PR.

Anyway, I have missed the mark here with @swhite2 I apologize. It's just that due to the way of our communication, pestering team members on issues/ PR pages IMO is also meh meh so I try to avoid it.

[Monviech]

Don't worry, you are not pestering when you ask questions. It helps with collaboration and planning. :)

[sopex]

@swhite2 I once again apologize for this. How do you want to play it? Shall I finish it and tag you for review? Shall I let you do it from the begining your way? Do you have any input? Thanks!

[swhite2]

@sopex No worries, to be honest this slipped my mind a bit. Given the scope, go ahead and finish it and tag me for review, I don't expect a lot of code to shift afterwards, but we'll see.

[sopex]

@swhite2 Let me know :)

[swhite2]

Couple of points:

• Let's rename it "Notes"
• I don't want a save button in there, so it's best to combine this with the edit mode of the widgets. Move the editable textbox to the rendered options form when "edit" is clicked, and the "notes" will just be rendered as text - no textbox around it. This will require a new type in https://github.com/opnsense/core/blob/master/src/opnsense/www/js/opnsense_widget_manager.js#L779-L817 (much like is the case with our form xmls).
• this.titleVisible = false; will probably work better for this widget, much like the picture widget.

[sopex]

Couple of points:

• Let's rename it "Notes"
• I don't want a save button in there, so it's best to combine this with the edit mode of the widgets. Move the editable textbox to the rendered options form when "edit" is clicked, and the "notes" will just be rendered as text - no textbox around it. This will require a new type in https://github.com/opnsense/core/blob/master/src/opnsense/www/js/opnsense_widget_manager.js#L779-L817 (much like is the case with our form xmls).
• this.titleVisible = false; will probably work better for this widget, much like the picture widget.

Thank you for your comments.

After some extensive testing, I am afraid that removing the save button makes this counterintuitive to use, especially on mobile.

That being said, I don't have any better ideas for removing the save button, only auto-saving, which might have issues of its own, so I will try to have something working as soon as possible.

[sopex]

@swhite2 Ready

You were absolutely right, it's much better this way!

[swhite2]

@sopex This does look a lot better indeed :)

Neat how it now streamlines the content into the dashboard config with the new option type.

[sopex]

@sopex This does look a lot better indeed :)

Neat how it now streamlines the content into the dashboard config with the new option type.

Indeed it's cool :)

[sopex]

@swhite2 Resolved

[swhite2]

Last nitpicks, looks good otherwise - thanks for bearing with me.

[sopex]

@swhite2
No worries, merge my other 2 PRs today, and I will forgive you. #10063 #9608 :)
Bonus points if you have any good ideas for the opnsense-auto problem #9916

Have a great rest of your day!