Fixes part of #5345: Implemented Reset functionality of Platform Parameters with new UI. #5894

theayushyadav11 · 2025-07-27T19:26:56Z

Fixes part of #5345:
This pull request introduces functionality to reset locally overridden platform parameters and feature flags to their server or default values, along with UI updates to support these features.

New Functionality

Platform Parameters

Added resetPlatformParameter method to handle resetting parameters to server/default values
Integrated reset functionality in presenter with proper state management
Added UI components for reset button with conditional visibility

Feature Flags

Implemented parallel resetFeatureFlag method for boolean flags
Added consistent reset behavior matching platform parameters
Integrated with existing feature flag UI components

UI Updates

Added observable fields to manage reset button state (isResetAvailable, isResetButtonActive)
Updated layouts to include reset sections for both platform parameters and feature flags
Ensured consistent styling and behavior between both reset implementations
Added a Save button which in the future PR will have an Alert Dialog attached.

Testing

Added comprehensive test coverage for both platform parameters and feature flags
Verified reset behavior persists across activity recreation
Confirmed proper state management during reset operations

Screen Recording

dashboard.mp4

Screenshots

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

…-auto-focus

…er-overridding

github-actions · 2025-07-27T20:43:08Z

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
PlatformParameterControllerDebugImpl.kt domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImpl.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PlatformParameterItemViewModel.kt app/src/main/java/org/oppia/android/app/devoptions/platformparameters/PlatformParameterItemViewModel.kt	This file is exempted from having a test file; skipping coverage check.
PlatformParametersFragmentPresenter.kt app/src/main/java/org/oppia/android/app/devoptions/platformparameters/PlatformParametersFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

.../java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImplTest.kt

…o reset-platform-parameters

BenHenning · 2025-09-05T06:20:27Z

Huh. I don't think my review is actually needed here. I don't see any files specific to owners that @adhiamboperes can't approve, so perhaps it is a holdover from an earlier version of the PR. Updating the reviewer list accordingly.

Please assign back if my approval is needed after @adhiamboperes's (I will quickly approve whatever remaining files need approval at that point since it's usually something small).

theayushyadav11 · 2025-09-05T09:16:51Z

Hi @adhiamboperes , PTAL.

adhiamboperes

Thanks @Rd4dev for the extensive review!

@theayushyadav11, the PR looks solid. I may not have been as thorough as I would like due to time and size, but the PR is in a good shape.

...src/main/java/org/oppia/android/app/devoptions/featureflags/FeatureFlagsFragmentPresenter.kt

app/src/main/java/org/oppia/android/app/devoptions/featureflags/FeatureFlagItemViewModel.kt

app/src/main/java/org/oppia/android/app/devoptions/featureflags/FeatureFlagsViewModel.kt

...main/java/org/oppia/android/app/devoptions/platformparameters/PlatformParametersViewModel.kt

app/src/main/res/layout/feature_flags_fragment.xml

...t/java/org/oppia/android/app/devoptions/platformparameters/PlatformParametersActivityTest.kt

.../java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImplTest.kt

model/src/main/proto/platform_parameter.proto

oppiabot · 2025-09-05T11:28:15Z

Unassigning @adhiamboperes since the review is done.

oppiabot · 2025-09-05T11:28:18Z

Hi @theayushyadav11, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

…o reset-platform-parameters

theayushyadav11 · 2025-09-05T12:01:39Z

PTAL @adhiamboperes

oppiabot · 2025-09-05T12:04:44Z

Unassigning @theayushyadav11 since a re-review was requested. @theayushyadav11, please make sure you have addressed all review comments. Thanks!

theayushyadav11 · 2025-09-05T14:06:58Z

Hi @adhiamboperes , I have addressed all the comments PTAL.

theayushyadav11 · 2025-09-05T14:38:00Z

Hi @BenHenning PTAL at this comment.

github-actions · 2025-09-05T14:47:05Z

Coverage Report

Results

Number of files assessed: 9
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
PlatformParameterItemViewModel.kt app/src/main/java/org/oppia/android/app/devoptions/platformparameters/PlatformParameterItemViewModel.kt	This file is exempted from having a test file; skipping coverage check.
PlatformParametersFragmentPresenter.kt app/src/main/java/org/oppia/android/app/devoptions/platformparameters/PlatformParametersFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
PlatformParametersFragment.kt app/src/main/java/org/oppia/android/app/devoptions/platformparameters/PlatformParametersFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PlatformParametersViewModel.kt app/src/main/java/org/oppia/android/app/devoptions/platformparameters/PlatformParametersViewModel.kt	This file is exempted from having a test file; skipping coverage check.
FeatureFlagsFragmentPresenter.kt app/src/main/java/org/oppia/android/app/devoptions/featureflags/FeatureFlagsFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
FeatureFlagItemViewModel.kt app/src/main/java/org/oppia/android/app/devoptions/featureflags/FeatureFlagItemViewModel.kt	This file is exempted from having a test file; skipping coverage check.
FeatureFlagsViewModel.kt app/src/main/java/org/oppia/android/app/devoptions/featureflags/FeatureFlagsViewModel.kt	This file is exempted from having a test file; skipping coverage check.
FeatureFlagsFragment.kt app/src/main/java/org/oppia/android/app/devoptions/featureflags/FeatureFlagsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PlatformParameterControllerDebugImpl.kt domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImpl.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

adhiamboperes

LGTM, thanks @theayushyadav11!.

Please see my comment about filing and issue to clarify test naming and outcomes.

.../java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImplTest.kt

theayushyadav11 and others added 17 commits July 14, 2025 12:21

disable auto focus

3f0fb45

resolve

71f2066

change

00a5f1f

Merge branch 'develop' into disable-auto-focus

4baf983

added check

3edd7c9

Merge remote-tracking branch 'origin/disable-auto-focus' into disable…

3eac6ca

…-auto-focus

removed tests

01cf323

working overrides

726d53c

added debugImpl tests

38ec177

added fragment test

055e88b

Merge remote-tracking branch 'upstream/develop' into platform-paramet…

4dbee61

…er-overridding

android lint fix

af26af3

added kdoc

451c5e1

modified tests

b0113b1

added integration test

8683623

added reset implementation

1652e67

added kdoc

1b175ae

theayushyadav11 requested review from a team as code owners July 27, 2025 19:26

theayushyadav11 requested review from BenHenning and removed request for a team July 27, 2025 19:26

theayushyadav11 marked this pull request as draft July 27, 2025 19:27

added debugImpl test

2052972

theayushyadav11 commented Jul 28, 2025

View reviewed changes

.../java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImplTest.kt Outdated Show resolved Hide resolved

theayushyadav11 and others added 2 commits July 28, 2025 23:05

added UI tests

d1fe959

Update PlatformParametersFragmentPresenter.kt

b50f6e1

Rd4dev reviewed Jul 30, 2025

View reviewed changes

.../java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImplTest.kt Outdated Show resolved Hide resolved

Rd4dev assigned theayushyadav11 Jul 30, 2025

added and arranged tests

8a3459d

theayushyadav11 added 2 commits September 5, 2025 03:38

lint exemptions

7ed90c5

Merge remote-tracking branch 'upstream/reset-platform-parameters' int…

9cf552e

…o reset-platform-parameters

BenHenning removed the request for review from a team September 5, 2025 06:20

BenHenning removed their assignment Sep 5, 2025

theayushyadav11 and others added 2 commits September 5, 2025 14:10

Merge branch 'develop' into reset-platform-parameters

545b042

nits

0bc242f

Merge branch 'develop' into reset-platform-parameters

c41615a

adhiamboperes requested changes Sep 5, 2025

View reviewed changes

oppiabot bot unassigned adhiamboperes Sep 5, 2025

oppiabot bot assigned theayushyadav11 Sep 5, 2025

theayushyadav11 added 2 commits September 5, 2025 17:27

nits

823d909

Merge remote-tracking branch 'upstream/reset-platform-parameters' int…

f46e5aa

…o reset-platform-parameters

oppiabot bot assigned adhiamboperes and unassigned theayushyadav11 Sep 5, 2025

nits

864658d

oppiabot bot assigned BenHenning Sep 5, 2025

adhiamboperes approved these changes Sep 5, 2025

View reviewed changes

.../java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImplTest.kt Show resolved Hide resolved

.../java/org/oppia/android/domain/platformparameter/PlatformParameterControllerDebugImplTest.kt Show resolved Hide resolved

adhiamboperes merged commit 5ed2f00 into develop Sep 5, 2025
37 checks passed

adhiamboperes deleted the reset-platform-parameters branch September 5, 2025 15:16

Rd4dev mentioned this pull request Sep 5, 2025

Fixes part of #5345: Implementing Force downloading . #5949

Merged

6 tasks

theayushyadav11 mentioned this pull request Sep 14, 2025

Fix the naming convention in tests for nonOverriddenValue . #5967

Open

Fixes part of #5345: Implemented Reset functionality of Platform Parameters with new UI. #5894

Fixes part of #5345: Implemented Reset functionality of Platform Parameters with new UI. #5894

Uh oh!

Conversation

theayushyadav11 commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Functionality

Platform Parameters

Feature Flags

UI Updates

Testing

Screen Recording

Screenshots

Essential Checklist

Uh oh!

github-actions bot commented Jul 27, 2025

Coverage Report

Results

Exempted coverage

Uh oh!

Uh oh!

Uh oh!

BenHenning commented Sep 5, 2025

Uh oh!

theayushyadav11 commented Sep 5, 2025

Uh oh!

adhiamboperes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oppiabot bot commented Sep 5, 2025

Uh oh!

oppiabot bot commented Sep 5, 2025

Uh oh!

theayushyadav11 commented Sep 5, 2025

Uh oh!

oppiabot bot commented Sep 5, 2025

Uh oh!

theayushyadav11 commented Sep 5, 2025

Uh oh!

theayushyadav11 commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Coverage Report

Results

Exempted coverage

Uh oh!

adhiamboperes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theayushyadav11 commented Jul 27, 2025 •

edited

Loading