Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Default owners for everything in the repo

* @opsmill/sa
119 changes: 68 additions & 51 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
---
name: Build and Deploy Docusaurus
name: CI
# yamllint disable rule:truthy rule:line-length
on:
pull_request:
push:
branches:
- main

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

env:
VALE_VERSION: "3.7.1"
UV_VERSION: "0.5.10"
VALE_VERSION: "3.13.0"
UV_VERSION: "0.9.18"
Comment on lines +18 to +19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# Check the file and git history to confirm previous versions
git log --oneline --all -p .github/workflows/ci.yml | head -100

Repository: opsmill/infrahub-exporter

Length of output: 2698


🌐 Web query:

UV 0.5.10 to 0.9.18 breaking changes migration guide

💡 Result:

Here’s a concise migration checklist for upgrading uv from 0.5.10 → 0.9.18 (key breaking changes and what to do). Sources cited inline.

  1. Pin / verify Python versions
  • 0.9.x changed default/available Python handling (Python 3.14 surfaced as a default/stable in 0.9.0). Pin the Python you expect (or test on 3.14) and update any CI images. If your builds rely on an implicit system Python, add explicit python-version constraints. (newreleases.io)
  1. Update build-backend bounds in pyproject.toml
  • If you have an upper bound for uv_build in [build-system], update it to a 0.9.x-compatible range (examples in docs show uv_build>=0.9.18,<0.10.0). Verify build-backend compatibility after upgrade. (docs.astral.sh)
  1. Review deprecated/changed CLI flags and commands
  • Some flags/behaviors were deprecated or changed across 0.9.x (e.g., deprecation warnings such as --project on uv init in 0.9.9). Audit scripts/automation that call uv CLI and adjust flags per current help output. Run uv -h / uv -h to detect mismatches. (github.com)
  1. uv publish and environment-variable behavior
  • Earlier versions had issues where uv publish didn’t read UV_PUBLISH_URL / UV_PUBLISH_TOKEN; test your publish workflow (and explicitly pass --publish-url/--token as a fallback). 0.9.x contains fixes/enhancements to publish handling—retest and adjust CI if necessary. (github.com)
  1. Configuration / tool settings
  • New configuration keys and flags landed across 0.9.x (example: accept --torch-backend in [tool.uv] in 0.9.18). Review your [tool.uv] config and environment variables for newly supported or renamed keys. (newreleases.io)
  1. New features that may change behavior
  • 0.9.x added features (resolver improvements, cache commands, export/sync changes, Python variant handling) that can alter resolver outcomes or CLI output — verify dependency resolution, lockfiles (uv.lock), and automation that parses uv output. Run a full install/lock and compare results. (github.com)
  1. Test matrix and CI
  • Run your full test matrix (all supported Python versions you target) under 0.9.18. Pay attention to interpreter detection changes and platform-specific messages that may affect automation. (github.com)
  1. Read the per-release notes / changelogs
  • For any remaining edge cases, consult the uv release notes / changelogs for each 0.6.x → 0.9.18 release to catch smaller breaking changes or behavioral tweaks you rely on. The project split changelogs by breaking version — use those files for detailed diffs. (git.joshthomas.dev)

If you want, I can:

  • generate a concrete changelog diff (0.5.10 → 0.9.18) with links to each release note, or
  • run a checklist against a sample pyproject.toml / CI config you paste.

Citations:


🌐 Web query:

Vale 3.7.1 to 3.13.0 breaking changes release notes

💡 Result:

Summary of notable breaking / backwards-impacting changes from Vale v3.7.1 → v3.13.0

  • Global/big breaking change (pre-v3.x you may already have encountered): v3.0 moved vocabularies from $StylesPath/Vocab → $StylesPath/config/vocabularies (users upgrading from v2→v3 must move them). [1]

  • v3.7.x → v3.7.1: bugfixes only (Julia parser added; fixes to matchToken behavior) — no breaking changes called out. [2]

  • v3.9.x: added comment-based controls (switching styles per-block; ignore individual matches). These change how inline comment config can be used and may interact with existing in-file config; not strictly breaking, but can affect behavior if you relied on older comment semantics. [3]

  • v3.10.0: built-in MDX support and a config change — it’s no longer necessary to set CommentDelimiters or use a [formats] association for Markdown. That change can alter how previously-customized Markdown/comment configurations behave. [4]

  • v3.11.0: added front-matter field linting (YAML/TOML/JSON) producing new scopes (e.g., text.frontmatter.title). This creates additional scopes that rules can target — can change matching behavior if you relied on older scope names. [5]

  • v3.12.0: introduced Views (new way to extract scoped content from structured files and source code). Views change how content is scoped/linted (can be breaking for workflows expecting the previous blueprint/format handling). [5]

  • v3.13.0: added tree-sitter support for Java source files (affects how Java files are parsed/linted); minor fixes for continuation-character errors. [6]

If you need, I can:

  • extract the exact changelog text for each release (3.8 → 3.13) or
  • produce a migration checklist (config settings to review and example changes).

Sources

  1. v3.0 breaking notes (vocab path change). [1] (newreleases.io)
  2. v3.7.1 changelog (fixes, Julia parser). [2] (newreleases.io)
  3. v3.9 (comment syntax features). [3] (newreleases.io)
  4. v3.10 (MDX support; CommentDelimiters/formats change). [4] (newreleases.io)
  5. v3.11 & v3.12 (front matter scopes; Views). [5] (github.com)
  6. v3.13 (tree-sitter Java; fixes). [6] (github.com)

Citations:


Test these tool versions for compatibility concerns.

These versions include significant changes that warrant testing:

  • UV 0.9.18: Python version handling changes, CLI flag deprecations, and resolver improvements (major jump from 0.5.x).
  • Vale 3.13.0: New scoping behavior, Views feature, and front-matter linting (includes multiple feature additions from 3.7.x).

Run the full test suite with these versions to ensure no unexpected behavior changes or build failures.

🤖 Prompt for AI Agents
.github/workflows/ci.yml lines 18-19 specify VALE_VERSION "3.13.0" and
UV_VERSION "0.9.18"; the reviewer asks these versions be validated for
compatibility. Update CI to run the full test suite with these exact tool
versions (or add a matrix job that includes them), run the test matrix
locally/CI, capture and fix any failures caused by changed CLI flags, Python
handling, resolver behavior, or Vale scoping/front-matter changes (e.g., adjust
CLI invocations, update Python compatibility layers, and modify Vale
config/rules as needed), then commit CI adjustments and any code/config fixes so
the pipeline passes with these versions.


jobs:
files-changed:
Expand All @@ -19,9 +27,9 @@ jobs:
documentation: ${{ steps.changes.outputs.documentation_all }}
python: ${{ steps.changes.outputs.python_all }}
yaml: ${{ steps.changes.outputs.yaml_all }}
markdown: ${{ steps.changes.outputs.markdown_all }}
steps:
- name: "Check out repository code"
uses: "actions/checkout@v4"
- uses: actions/checkout@v5
- name: Check for file changes
uses: opsmill/[email protected]
id: changes
Expand All @@ -32,42 +40,53 @@ jobs:
python-lint:
if: needs.files-changed.outputs.python == 'true'
needs: ["files-changed"]
runs-on: "ubuntu-latest"
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: "Check out repository code"
uses: "actions/checkout@v4"
with:
submodules: true
- uses: actions/checkout@v5
- name: Install uv
uses: astral-sh/setup-uv@v4
uses: astral-sh/setup-uv@v7
with:
version: ${{ env.UV_VERSION }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.12'
- name: "Install dependencies"
run: "uv sync --frozen --group dev"
- name: "Linting: ruff check"
run: "uv run ruff check ."
- name: "Linting: ruff format"
run: "uv run ruff format --check --diff"
- run: uv sync
- name: Check code formatting
run: |
uv run ruff format --check --diff
uv run ruff check --select I .
- name: Run linters
run: uv run ruff check
- name: Run type checks
run: uv run mypy .

yaml-lint:
if: needs.files-changed.outputs.yaml == 'true'
needs: ["files-changed"]
runs-on: "ubuntu-latest"
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: "Check out repository code"
uses: "actions/checkout@v4"
- uses: actions/checkout@v5
- name: Install uv
uses: astral-sh/setup-uv@v7
with:
submodules: true
- name: "Setup environment"
run: "pip install yamllint==1.35.1"
- name: "Linting: yamllint"
run: "yamllint -s ."
version: ${{ env.UV_VERSION }}
- run: uv sync
- name: Run yamllint
run: uv run yamllint -s .

markdown-lint:
if: needs.files-changed.outputs.markdown == 'true'
needs: ["files-changed"]
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v5
- uses: actions/setup-node@v6
with:
node-version: 20
- name: Install markdownlint-cli
run: npm install -g markdownlint-cli
- name: Run markdownlint
run: markdownlint "**/*.{md,mdx}"

documentation:
defaults:
Expand All @@ -78,48 +97,46 @@ jobs:
!contains(needs.*.result, 'failure') &&
!contains(needs.*.result, 'cancelled') &&
needs.files-changed.outputs.documentation == 'true'
needs: ["files-changed", "yaml-lint", "python-lint"]
runs-on: "ubuntu-22.04"
needs: ["files-changed", "yaml-lint", "python-lint", "markdown-lint"]
runs-on: ubuntu-22.04
timeout-minutes: 5
steps:
- name: "Check out repository code"
uses: "actions/checkout@v4"
- uses: actions/checkout@v5
with:
submodules: true
- name: Install NodeJS
uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version: 20
cache: 'npm'
cache-dependency-path: docs/package-lock.json
- name: "Install dependencies"
- name: Install Node dependencies
working-directory: docs
run: npm install
- name: "Setup Python environment"
run: "pip install invoke toml"
- name: "Build docs website"
run: "invoke docs"
- name: Install uv
uses: astral-sh/setup-uv@v7
with:
version: ${{ env.UV_VERSION }}
- run: uv sync
working-directory: ./
- name: Build docs website
run: uv run invoke docs

validate-documentation-style:
if: |
always() && !cancelled() &&
!contains(needs.*.result, 'failure') &&
!contains(needs.*.result, 'cancelled')
needs: ["files-changed", "yaml-lint", "python-lint"]
runs-on: "ubuntu-22.04"
needs: ["files-changed", "yaml-lint", "python-lint", "markdown-lint"]
runs-on: ubuntu-22.04
timeout-minutes: 5
steps:
- name: "Check out repository code"
uses: "actions/checkout@v4"
- uses: actions/checkout@v5
with:
submodules: true

# The official GitHub Action for Vale doesn't work, installing manually instead:
# https://github.com/errata-ai/vale-action/issues/103
# Manual installation - GitHub Action is broken
- name: Download Vale
run: |
curl -sL "https://github.com/errata-ai/vale/releases/download/v${VALE_VERSION}/vale_${VALE_VERSION}_Linux_64-bit.tar.gz" -o vale.tar.gz
tar -xzf vale.tar.gz
env:
VALE_VERSION: ${{ env.VALE_VERSION }}
- name: "Validate documentation style"
run: ./vale $(find ./docs -type f \( -name "*.mdx" -o -name "*.md" \) )
- name: Validate documentation style
run: ./vale $(find ./docs/docs -type f \( -name "*.mdx" -o -name "*.md" \))
1 change: 1 addition & 0 deletions .yamllint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ extends: default
ignore: |
/.git
/.github
/.venv
/docs/node_modules

rules:
Expand Down
4 changes: 3 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
## Project Overview

Infrahub Exporter is a Python microservice that bridges Infrahub (infrastructure management platform) with monitoring systems. It provides:

- Prometheus metrics export via `/metrics` endpoint
- Dynamic service discovery for Prometheus via `/sd/{query_name}` endpoints
- OpenTelemetry (OTLP) metrics export via gRPC
Expand Down Expand Up @@ -52,14 +53,15 @@ The codebase follows an async event-driven pattern with four core modules:
## Configuration

Configuration is YAML-based (see `examples/config.yml`). Key sections:

- `infrahub`: Server address, API token, branch
- `exporters`: Enable/configure Prometheus and OTLP exporters
- `service_discovery`: GraphQL queries for dynamic target discovery
- `metrics`: Node kinds to collect with optional filters

## Python Version

Targets Python 3.10-3.12 (see `pyproject.toml`).
Targets Python 3.10-3.13 (see `pyproject.toml`).

## Type Checking

Expand Down
Loading