-
Notifications
You must be signed in to change notification settings - Fork 0
chore: update CI pipeline to be consistent #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
petercrocker
wants to merge
7
commits into
main
Choose a base branch
from
pmc-20251228-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+540
−163
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
838e75a
chore: align repository with OpsMill standards
petercrocker 5dc0217
fix: resolve linting issues
petercrocker d3c9c30
ruff format
petercrocker f36dad7
fix: address CodeRabbit review nitpicks
petercrocker a777560
fix: address CodeRabbit review nitpicks
petercrocker 75fea5f
chore: add markdownlint to invoke lint task
petercrocker 0a0d764
Merge branch 'pmc-20251228-updates' of github.com:opsmill/infrahub-ex…
petercrocker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Default owners for everything in the repo | ||
|
|
||
| * @opsmill/sa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,22 @@ | ||
| --- | ||
| name: Build and Deploy Docusaurus | ||
| name: CI | ||
| # yamllint disable rule:truthy rule:line-length | ||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| env: | ||
| VALE_VERSION: "3.7.1" | ||
| UV_VERSION: "0.5.10" | ||
| VALE_VERSION: "3.13.0" | ||
| UV_VERSION: "0.9.18" | ||
|
|
||
| jobs: | ||
| files-changed: | ||
|
|
@@ -19,9 +27,9 @@ jobs: | |
| documentation: ${{ steps.changes.outputs.documentation_all }} | ||
| python: ${{ steps.changes.outputs.python_all }} | ||
| yaml: ${{ steps.changes.outputs.yaml_all }} | ||
| markdown: ${{ steps.changes.outputs.markdown_all }} | ||
| steps: | ||
| - name: "Check out repository code" | ||
| uses: "actions/checkout@v4" | ||
| - uses: actions/checkout@v5 | ||
| - name: Check for file changes | ||
| uses: opsmill/[email protected] | ||
| id: changes | ||
|
|
@@ -32,42 +40,53 @@ jobs: | |
| python-lint: | ||
| if: needs.files-changed.outputs.python == 'true' | ||
| needs: ["files-changed"] | ||
| runs-on: "ubuntu-latest" | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: "Check out repository code" | ||
| uses: "actions/checkout@v4" | ||
| with: | ||
| submodules: true | ||
| - uses: actions/checkout@v5 | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v4 | ||
| uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| version: ${{ env.UV_VERSION }} | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
| - name: "Install dependencies" | ||
| run: "uv sync --frozen --group dev" | ||
| - name: "Linting: ruff check" | ||
| run: "uv run ruff check ." | ||
| - name: "Linting: ruff format" | ||
| run: "uv run ruff format --check --diff" | ||
| - run: uv sync | ||
| - name: Check code formatting | ||
| run: | | ||
| uv run ruff format --check --diff | ||
| uv run ruff check --select I . | ||
| - name: Run linters | ||
| run: uv run ruff check | ||
| - name: Run type checks | ||
| run: uv run mypy . | ||
|
|
||
| yaml-lint: | ||
| if: needs.files-changed.outputs.yaml == 'true' | ||
| needs: ["files-changed"] | ||
| runs-on: "ubuntu-latest" | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: "Check out repository code" | ||
| uses: "actions/checkout@v4" | ||
| - uses: actions/checkout@v5 | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| submodules: true | ||
| - name: "Setup environment" | ||
| run: "pip install yamllint==1.35.1" | ||
| - name: "Linting: yamllint" | ||
| run: "yamllint -s ." | ||
| version: ${{ env.UV_VERSION }} | ||
| - run: uv sync | ||
| - name: Run yamllint | ||
| run: uv run yamllint -s . | ||
|
|
||
| markdown-lint: | ||
| if: needs.files-changed.outputs.markdown == 'true' | ||
| needs: ["files-changed"] | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 20 | ||
| - name: Install markdownlint-cli | ||
| run: npm install -g markdownlint-cli | ||
| - name: Run markdownlint | ||
| run: markdownlint "**/*.{md,mdx}" | ||
|
|
||
| documentation: | ||
| defaults: | ||
|
|
@@ -78,48 +97,46 @@ jobs: | |
| !contains(needs.*.result, 'failure') && | ||
| !contains(needs.*.result, 'cancelled') && | ||
| needs.files-changed.outputs.documentation == 'true' | ||
| needs: ["files-changed", "yaml-lint", "python-lint"] | ||
| runs-on: "ubuntu-22.04" | ||
| needs: ["files-changed", "yaml-lint", "python-lint", "markdown-lint"] | ||
| runs-on: ubuntu-22.04 | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: "Check out repository code" | ||
| uses: "actions/checkout@v4" | ||
| - uses: actions/checkout@v5 | ||
| with: | ||
| submodules: true | ||
| - name: Install NodeJS | ||
| uses: actions/setup-node@v4 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 20 | ||
| cache: 'npm' | ||
| cache-dependency-path: docs/package-lock.json | ||
| - name: "Install dependencies" | ||
| - name: Install Node dependencies | ||
| working-directory: docs | ||
| run: npm install | ||
| - name: "Setup Python environment" | ||
| run: "pip install invoke toml" | ||
| - name: "Build docs website" | ||
| run: "invoke docs" | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| version: ${{ env.UV_VERSION }} | ||
| - run: uv sync | ||
| working-directory: ./ | ||
| - name: Build docs website | ||
| run: uv run invoke docs | ||
|
|
||
| validate-documentation-style: | ||
| if: | | ||
| always() && !cancelled() && | ||
| !contains(needs.*.result, 'failure') && | ||
| !contains(needs.*.result, 'cancelled') | ||
| needs: ["files-changed", "yaml-lint", "python-lint"] | ||
| runs-on: "ubuntu-22.04" | ||
| needs: ["files-changed", "yaml-lint", "python-lint", "markdown-lint"] | ||
| runs-on: ubuntu-22.04 | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: "Check out repository code" | ||
| uses: "actions/checkout@v4" | ||
| - uses: actions/checkout@v5 | ||
| with: | ||
| submodules: true | ||
|
|
||
| # The official GitHub Action for Vale doesn't work, installing manually instead: | ||
| # https://github.com/errata-ai/vale-action/issues/103 | ||
| # Manual installation - GitHub Action is broken | ||
| - name: Download Vale | ||
| run: | | ||
| curl -sL "https://github.com/errata-ai/vale/releases/download/v${VALE_VERSION}/vale_${VALE_VERSION}_Linux_64-bit.tar.gz" -o vale.tar.gz | ||
| tar -xzf vale.tar.gz | ||
| env: | ||
| VALE_VERSION: ${{ env.VALE_VERSION }} | ||
| - name: "Validate documentation style" | ||
| run: ./vale $(find ./docs -type f \( -name "*.mdx" -o -name "*.md" \) ) | ||
| - name: Validate documentation style | ||
| run: ./vale $(find ./docs/docs -type f \( -name "*.mdx" -o -name "*.md" \)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ extends: default | |
| ignore: | | ||
| /.git | ||
| /.github | ||
| /.venv | ||
| /docs/node_modules | ||
|
|
||
| rules: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: opsmill/infrahub-exporter
Length of output: 2698
🌐 Web query:
UV 0.5.10 to 0.9.18 breaking changes migration guide💡 Result:
Here’s a concise migration checklist for upgrading uv from 0.5.10 → 0.9.18 (key breaking changes and what to do). Sources cited inline.
If you want, I can:
Citations:
🌐 Web query:
Vale 3.7.1 to 3.13.0 breaking changes release notes💡 Result:
Summary of notable breaking / backwards-impacting changes from Vale v3.7.1 → v3.13.0
Global/big breaking change (pre-v3.x you may already have encountered): v3.0 moved vocabularies from $StylesPath/Vocab → $StylesPath/config/vocabularies (users upgrading from v2→v3 must move them). [1]
v3.7.x → v3.7.1: bugfixes only (Julia parser added; fixes to matchToken behavior) — no breaking changes called out. [2]
v3.9.x: added comment-based controls (switching styles per-block; ignore individual matches). These change how inline comment config can be used and may interact with existing in-file config; not strictly breaking, but can affect behavior if you relied on older comment semantics. [3]
v3.10.0: built-in MDX support and a config change — it’s no longer necessary to set CommentDelimiters or use a [formats] association for Markdown. That change can alter how previously-customized Markdown/comment configurations behave. [4]
v3.11.0: added front-matter field linting (YAML/TOML/JSON) producing new scopes (e.g., text.frontmatter.title). This creates additional scopes that rules can target — can change matching behavior if you relied on older scope names. [5]
v3.12.0: introduced Views (new way to extract scoped content from structured files and source code). Views change how content is scoped/linted (can be breaking for workflows expecting the previous blueprint/format handling). [5]
v3.13.0: added tree-sitter support for Java source files (affects how Java files are parsed/linted); minor fixes for continuation-character errors. [6]
If you need, I can:
Sources
Citations:
Test these tool versions for compatibility concerns.
These versions include significant changes that warrant testing:
Run the full test suite with these versions to ensure no unexpected behavior changes or build failures.
🤖 Prompt for AI Agents