Skip to content

Conversation

@FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Jan 9, 2026

Summary by CodeRabbit

Bug Fixes

  • Fixed HFID casting handling for non-UUID strings.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

Walkthrough

This pull request updates the project to version 1.18.1, a patch release. The version number in pyproject.toml is incremented from 1.18.0 to 1.18.1, and a corresponding changelog entry is added to CHANGELOG.md dated 2026-01-08. The changelog documents a fix for issue #723, which involves reverting a change related to HFID casting of non-UUID strings.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: bumping the version to 1.18.1 and updating the changelog, which are the exact modifications shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 263945d and 2fc9790.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • CHANGELOG.md
  • pyproject.toml
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{md,mdx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{md,mdx}: Use text language for directory structure code blocks in markdown documentation
Add blank lines before and after lists in markdown documentation
Always specify language in fenced code blocks in markdown documentation

Files:

  • CHANGELOG.md
🧠 Learnings (2)
📚 Learning: 2025-12-10T17:13:08.136Z
Learnt from: CR
Repo: opsmill/infrahub-sdk-python PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-10T17:13:08.136Z
Learning: Applies to infrahub_sdk/**/*.py : Follow async/sync dual pattern for new features in the Python SDK

Applied to files:

  • CHANGELOG.md
📚 Learning: 2025-12-10T17:13:08.136Z
Learnt from: CR
Repo: opsmill/infrahub-sdk-python PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-10T17:13:08.136Z
Learning: Applies to infrahub_sdk/client.py : Always provide both async and sync versions of client implementations in InfrahubClient

Applied to files:

  • pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: unit-tests (3.13)
  • GitHub Check: unit-tests (3.14)
  • GitHub Check: unit-tests (3.11)
  • GitHub Check: unit-tests (3.10)
  • GitHub Check: unit-tests (3.12)
  • GitHub Check: documentation
  • GitHub Check: integration-tests-latest-infrahub
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
pyproject.toml (1)

3-3: Version bump aligns with semantic versioning for patch release.

The version increment from 1.18.0 to 1.18.1 is appropriate for a patch release that reverts a problematic change, as documented in the changelog.

CHANGELOG.md (1)

13-17: Changelog entry properly formatted and aligned with version bump.

The new 1.18.1 entry follows the established format with proper versioning, date, blank lines before/after list items, and a clear reference to the reverted issue. The entry is correctly positioned after the towncrier marker and before the 1.18.0 release notes.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2fc9790
Status: ✅  Deploy successful!
Preview URL: https://08d16b1d.infrahub-sdk-python.pages.dev
Branch Preview URL: https://release-1-18-1.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##           stable     #742   +/-   ##
=======================================
  Coverage   80.30%   80.30%           
=======================================
  Files         115      115           
  Lines        9874     9874           
  Branches     1518     1518           
=======================================
  Hits         7929     7929           
  Misses       1417     1417           
  Partials      528      528           
Flag Coverage Δ
integration-tests 41.30% <ø> (ø)
python-3.10 50.93% <ø> (ø)
python-3.11 50.93% <ø> (+0.02%) ⬆️
python-3.12 50.91% <ø> (ø)
python-3.13 50.91% <ø> (ø)
python-3.14 52.53% <ø> (-0.03%) ⬇️
python-filler-3.12 24.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FragmentedPacket FragmentedPacket merged commit d116aa3 into stable Jan 9, 2026
21 checks passed
@FragmentedPacket FragmentedPacket deleted the release-1.18.1 branch January 9, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants