Skip to content

🐛 fix(imcp): Remove auto-register condition and update comments #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eryajf merged 1 commit into from
Jan 15, 2026
Merged

🐛 fix(imcp): Remove auto-register condition and update comments #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions internal/imcp/external.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,8 @@ func (s *MCPServer) RegisterExternalMCPTools(ctx context.Context, manager *mcpcl

// 遍历所有外部 MCP 客户端
for _, mcpClient := range manager.List() {
if !mcpClient.Config.AutoRegister {
logx.Info("⏭️ Skip auto-register for MCP: %s", mcpClient.Config.Name)
continue
}

// 只要 MCP 客户端已加载到 Manager 中，就注册其工具
// 注意：Manager.LoadFromConfig 已经过滤了未启用的服务器
registeredCount := 0
failedCount := 0

Expand Down
3 changes: 2 additions & 1 deletion internal/mcpclient/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ func (m *Manager) CloseAll() {
}

// RegisterFromDB 从数据库模型注册 MCP 客户端
// 注意: autoRegister 参数已废弃，现在只要 MCP 服务器被成功注册，其工具就会被自动注册
func (m *Manager) RegisterFromDB(name string, serverType string, command string, args []string, env map[string]string, baseURL string, headers map[string]string, timeout int, toolPrefix string, autoRegister bool) error {
// 创建配置
cfg := &config.MCPServerConfig{
Expand All @@ -342,7 +343,7 @@ func (m *Manager) RegisterFromDB(name string, serverType string, command string,
Timeout: timeout,
IsActive: true,
ToolPrefix: toolPrefix,
AutoRegister: autoRegister,
AutoRegister: autoRegister, // 已废弃，保留仅为向后兼容
}

return m.Register(name, cfg)
Expand Down
Loading