Locking cleanups #537
Open
Locking cleanups #537
+36
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at ee65f35; would you reconsider the stateful locking approach? If the naked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the multi-thread locking I saw many raw lock & unlock calls. This PR uses lock guard objects where applicable and introduces an
optional<guard>as a lazy man'sunique_lock. Looking at the removed unlock conditions you will find the same condition that was used to conditionally lock in the first place.I unnamed some temporary guard objects just to avoid name clashes.
Some raw and even unmatched lock & unlock calls remain for some less trivial use cases.
I built and tested successfully with Cyberpunk 2077 on AMD with DLSS frame generation only. Please review carefully as I have little experience with the project and hardly tested all use cases.