Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kernel][x86] Multiple checks in isr_handler #39

Closed
Supercip971 opened this issue Aug 21, 2021 · 3 comments · Fixed by #41
Closed

[kernel][x86] Multiple checks in isr_handler #39

Supercip971 opened this issue Aug 21, 2021 · 3 comments · Fixed by #41
Labels

Comments

@Supercip971
Copy link

Supercip971 commented Aug 21, 2021

why not use:

if(i != 0 && i != 6 && i != 14)

instead of using 13 else if with the same action inside ?

(can't do a pr as I can't build the toolchain (#37) )

@rdmsr
Copy link

rdmsr commented Aug 21, 2021

also pls use switch

@nimelehin
Copy link
Collaborator

nimelehin commented Aug 21, 2021

Agree to change this, @Supercip971. If you want to create a pr, for a temporary solution you can use LLVM Toolchain.

@nimelehin nimelehin changed the title Int_no multiple check [kernel][x86] Multiple checks in isr_handler Aug 21, 2021
@bellrise
Copy link
Contributor

Fixed this on my fork, will be turned into a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants