Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #39 and keyboard driver #40

Closed
wants to merge 2 commits into from
Closed

Fix issue #39 and keyboard driver #40

wants to merge 2 commits into from

Conversation

bellrise
Copy link
Contributor

The `_generic_keyboard_apply_mod` function now uses a map instead of a switch
case for better readability. Some code has been refractored. Fixed a bug
where Shift+3 and Shift+4 keys did not match the standard US keyboard layout.
The isr_handler now uses a switch case instead of too many else ifs.
Code has been grouped together, properly aligned and shortened. Switched
the if and else cases so the "truthy" one comes first, making it easier
to think about.
@nimelehin
Copy link
Collaborator

Thanks for the PR! The changes look great!

The only things you have to change is formatting of your code. At this project we use WebKit code-style. You can run clang-format.

The commit naming is slightly different also. Like [kernel/drivers] -> [kernel][drivers] and the same goes for [kernel/x86] -> [kernel][x86]

@bellrise
Copy link
Contributor Author

bellrise commented Aug 23, 2021

Sure I'll fix that, let me just remake the PR

@bellrise bellrise closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kernel][x86] Multiple checks in isr_handler
2 participants