Spread call/eth #43
Open
Spread call/eth #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparnakr
reviewed
Nov 30, 2021
| @@ -195,17 +181,17 @@ contract ShortOTokenActionWithSwap is IAction, AirswapBase, RollOverBase { | |||
| function flashMintAndSellOToken(uint256 optionsToSell, uint256 premium, address counterparty) external onlyOwner { | |||
| //0. Initial Logic Checks | |||
| //require(counterparty.add != address(0), "Invalid counterparty address"); | |||
There was a problem hiding this comment.
probs need to uncomment this and implement a signature scheme to make sure the counterparty is ok with this transaction
aparnakr
reviewed
Nov 30, 2021
aparnakr
reviewed
Nov 30, 2021
aparnakr
reviewed
Nov 30, 2021
aparnakr
reviewed
Nov 30, 2021
Comment on lines
+226
to
230
| IWETH(asset).withdraw(assetToWithdraw); | ||
|
|
||
| // send fee to recipient | ||
| (bool success1, ) = feeRecipient.call{ value: fee }(''); | ||
| require(success1, 'O9'); |
There was a problem hiding this comment.
could just send fee in ETH, though not a big issue
aparnakr
reviewed
Nov 30, 2021
aparnakr
reviewed
Nov 30, 2021
aparnakr
reviewed
Nov 30, 2021
aparnakr
reviewed
Nov 30, 2021
aparnakr
reviewed
Nov 30, 2021
aparnakr
reviewed
Nov 30, 2021
aparnakr
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Generally good direction!
Left some comments to make changes :)
TLDR:
- We should implement a signature scheme to make sure the counterparty approves this particular amount of options, this spread and this premium
- In the tests, since its all in weth and there is no hidden fees, its better to check the exact amount than to estimate / approximate values
Co-authored-by: aparnakr <[email protected]>
Co-authored-by: aparnakr <[email protected]>
Co-authored-by: aparnakr <[email protected]>
Co-authored-by: aparnakr <[email protected]>
* added signature schema * added signature schema * clean eslint * view instead of pure * fixed vault test * fixing coverage test * added MM vault count * removed unused libraries * Update contracts/actions/ShortOTokenActionWithSwap.sol Co-authored-by: aparnakr <[email protected]> * Update contracts/actions/ShortOTokenActionWithSwap.sol Co-authored-by: aparnakr <[email protected]> * added required order > otoken expiry * use only order as param for flashMintAndSellOToken * removed isSenderAuthorized * removed delegated logic * removed kind and id * reanme higherToken insteadof token * removed signerMinimumNonce * removed affiliate * Update contracts/utils/RollOverBase.sol Co-authored-by: aparnakr <[email protected]> Co-authored-by: aparnakr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.