Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of position sometimes reloads randomly #454

Closed
wants to merge 18 commits into from

Conversation

deepthinker250
Copy link
Contributor

@deepthinker250 deepthinker250 commented May 12, 2022

Task:

Position sometimes reloads randomly

Description

This loading issue isn't related to API calls. It happens when calculating position fees which involve a lot of big numbers calculation. So it only occurs when the computer is slow. This PR removes the fees calculation loading to avoid flickering. I confirmed it's fixed by throttling CPU 6x.

Fixes # (issue) #365

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Document update

How Has This Been Tested

Please describe how to test to verify the changes. Provide instructions so we can reproduce.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Added video recordings if it is a UI change

@vercel
Copy link

vercel bot commented May 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
continuouscall ✅ Ready (Inspect) Visit Preview May 12, 2022 at 3:51AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant