Fix position flickering issue #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It's still happening for me! Screen.Recording.2022-05-13.at.8.50.30.am.mov |
|
@KMKoushik I'm struggling with reproducing it on my local. Can we schedule 20 minutes to pair on Monday your time? |
KMKoushik
approved these changes
May 22, 2022
KMKoushik
force-pushed
the
365-position-reloads
branch
from
0b475d8 to
33df81e
Compare
KMKoushik
force-pushed
the
365-position-reloads
branch
from
33df81e to
4c47466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task:
Position sometimes reloads randomly
Description
This loading issue isn't related to API calls. It happens when calculating position fees which involve a lot of big numbers calculation. So it only occurs when the computer is slow. This PR removes the fees calculation loading to avoid flickering. I confirmed it's fixed by throttling CPU 6x.
Fixes # (issue) #365
Type of change
How Has This Been Tested
Please describe how to test to verify the changes. Provide instructions so we can reproduce.
Checklist