You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What this PR does / why we need it:
This PR contains fixes for reconciliation errors caused by some changes from #456:
in nsg_reconciler.go and subnet_reconciler.go kept the reconcile function the same it was before until we will figure out how to use ptr.toNSGSlice and ptr.toSubnetSlice without causing reconciliation errors
The reason will be displayed to describe this comment to others. Learn more.
Do you mind in the PR comment detailing what issues are being fixed? I'm just trying to understand some of the changes better and I think having them in the main PR body would help me.
Unit tests output:
github.com/oracle/cluster-api-provider-oci coverage: 0.0% of statements
ok github.com/oracle/cluster-api-provider-oci/api/v1beta1 50.606s coverage: 23.3% of statements
ok github.com/oracle/cluster-api-provider-oci/api/v1beta2 0.032s coverage: 16.0% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/config 0.036s coverage: 86.1% of statements
github.com/oracle/cluster-api-provider-oci/cloud/metrics coverage: 0.0% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/ociutil 0.010s coverage: 15.9% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/ociutil/ptr 0.022s coverage: 100.0% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/scope 23.946s coverage: 74.3% of statements
github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks coverage: 0.0% of statements
github.com/oracle/cluster-api-provider-oci/cloud/services/base coverage: 0.0% of statements
github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/compute [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/identity [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/vcn [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests/mock_workrequests coverage: 0.0% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/util 0.177s coverage: 60.5% of statements
ok github.com/oracle/cluster-api-provider-oci/controllers 2.822s coverage: 59.2% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1 13.700s coverage: 15.3% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2 0.027s coverage: 5.8% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/controllers 1.275s coverage: 56.3% of statements
github.com/oracle/cluster-api-provider-oci/feature coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/version [no test files]
grep -v 'zz_generated' coverage.out > coverage_filtered.out
e2e tests output:
Ran 9 of 31 Specs in 3970.481 seconds
SUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 22 Skipped
OCA VerifiedAll contributors have signed the Oracle Contributor Agreement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oracle-contributor-agreement
bot
added
the
OCA Verified
What this PR does / why we need it:
This PR contains fixes for reconciliation errors caused by some changes from #456: