Initial setup of unit tests #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
sid-srini
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Thanks a lot @Achal1607 for getting the unit tests framework added.
Please do rebase against main after merging #310.
- That should remove many of the files/changes from the scope of this PR.
- Some work maybe needed to incorporate the changes on newly added tests on main like the localisation tests.
Most of my comments are queries for clarification, with few minor code suggestions.
Thanks a lot.
Achal1607
force-pushed
the
initial-unit-tests-setup
branch
from
65a34f3
to
0afd0c8
Compare
Achal1607
force-pushed
the
initial-unit-tests-setup
branch
4 times, most recently
from
17cab36
to
e1402de
Compare
Achal1607
force-pushed
the
initial-unit-tests-setup
branch
2 times, most recently
from
7482c62
to
c8a23a4
Compare
added unit tests for JDK Downloader view
updated license header
Achal1607
force-pushed
the
initial-unit-tests-setup
branch
from
c8a23a4
to
1deb2db
Compare
sid-srini
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an initial setup for unit testing to help validate fixes more quickly, without the need for a full NetBeans environment and VS Code UI runs. This setup includes sample unit tests for
JDKDownloaderViewinview.tsand adds few development dependencies for testing and mocking. A few VS Code-related mocks are also included.List of DevDependencies added and Justification:
@istanbuljs/nyc-config-typescript:A code coverage tool, with TypeScript support, ensuring code coverage reporting for TypeScript code.
@types/chai&chai:chaiis a popular assertion library used for writing readable and expressive test assertions.@types/chaiprovides TypeScript definitions forchai.@types/sinon&sinon:sinonis a library for creating mocks, spies, and stubs, useful for isolating and testing code components.@types/sinonprovides TypeScript definitions.ts-mockito:Provides a simpler API for creating mocks in TypeScript, offering an alternative to
sinonfor creating clean, readable mocks in TypeScript. Sinon doesn't have support for mocking interfaces and namesapce. So, it is also required.vscode-uri:Used for handling and manipulating URIs in a way consistent with VS Code’s own URI utilities, especially useful for file and path manipulations within tests.