Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SecurityManager #318

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Disable SecurityManager #318

merged 2 commits into from
Nov 4, 2024

Conversation

lahodaj
Copy link
Member

@lahodaj lahodaj commented Nov 1, 2024

As consequence of JEP-486, it will not be possible to set SecurityManager. The JEP is currently Proposed to Target for JDK 24:
https://mail.openjdk.org/pipermail/jdk-dev/2024-November/009601.html

The NetBeans back we use is currently setting a SecurityManager, and will fail to start with the updated JDK. Inside the NetBeans project, there's a motion to remove the SecurityManager:
apache/netbeans#7928

This patch proposed herein is a temporary attempt to disable the SecurityManager inside the extension, until the above PR is finished in one way or another, and until we upgrade to the version of NetBeans that will include it.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 1, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lahodaj for incorporating this. LGTM 👍

@sid-srini sid-srini merged commit 2115aad into oracle:main Nov 4, 2024
3 checks passed
@sid-srini sid-srini added this to the JVSC 23.0.1 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants