VECTOR Support #146
Merged
VECTOR Support #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Closed
|
Failing tests will be resolved with #145 |
jeandelavarene
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds support for the VECTOR data type introduced in Oracle Database 23ai. It requires an update of the Oracle JDBC dependency to version 23.4.
Oracle R2DBC will use the oracle.sql.VECTOR class of Oracle JDBC as the default mapping for VECTOR data. This class provides conversions to and from numeric arrays, such as float[], so I think it will offer a good solution when integrating with ML libraries that also expose vectors as primitive numeric arrays.
Numeric arrays, such as
float[]are already defined as a default mapping forARRAYdata. This default mapping appears in Section 14.1 of the R2DBC Specification. Also notable is that abyte[]would be mapped to aRAWby the underlying Oracle JDBC Driver. The need for oracle.sql.VECTOR as an intermediate mapping arises due to these existing mappings.A new VECTOR type code is added to
OracleR2dbcTypes. This type code is used by metadata classes to identify VECTOR data. This type code is also used to register OUT parameters. It can even be used for IN parameters, and this will allow users to directly bind primitive numeric arrays, without the need for an intermediate conversion to oracle.sql.VECTOR.There is a known defect which will prevent
Statement.returningGeneratedValues(String...)from returning VECTOR data. The defect will be resolved in the next release of Oracle JDBC. Strictly speaking, this means Oracle R2DBC does not fully support VECTOR, as it does not support thereturningGeneratedValuesmethod. But in all other cases, aside from returning values from DML, I think that almost-but-not-quite-full-support of VECTOR is valuable for our users. Users who need to return VECTOR from DML can use a temporary workaround which I've documented in the README.