Svelte test fixture: remove unused demo dependencies#1654
Draft
xormania wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
I looked into how you do things. I'll update PRs. BTW - I like what you're doing, you've answered some useful context issues. I get it now. |
Drop the SvelteKit demo-template baggage that no test exercises: @fontsource/fira-mono, @neoconfetti/svelte, @tailwindcss/vite and tailwindcss, along with their only usages (the layout.css imports, the sverdle page's confetti effect, and the tailwind vite plugin). A regenerated lockfile shrinks from 119 to 91 package entries (-24%). rolldown and lightningcss remain: they are vite's own dependencies, not tailwind's. Test-relevant files are untouched: tests reference the sverdle page only as an expected member of reference/rename result sets, and its $lib imports (game.ts, Words.svelte) are preserved. Verified: clean npm install + svelte-kit sync + full svelte suite (16/16) against the trimmed fixture. Note: oraios#1648 commits a package-lock.json generated from the previous dependency set; whichever change lands second must regenerate it.
xormania
force-pushed
the
fix/svelte-fixture-trim
branch
from
d49f5d3 to
c180586
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes SvelteKit demo-template dependencies that no test exercises:
@fontsource/fira-mono,@neoconfetti/svelte,@tailwindcss/vite, andtailwindcss, along with their only usages (thelayout.cssimports, the sverdle page's confetti effect, and the tailwind vite plugin).Why
npm install/svelte-kit sync.rolldown/lightningcssremain: they are vite's own dependencies, not tailwind's.Test safety
$libimports (game.ts,Words.svelte) — which put it in those result sets — are untouched.npm install+svelte-kit sync+ full svelte suite (16/16) against the trimmed fixture.Sequencing (why this is a draft)
#1648 commits a fixture
package-lock.jsongenerated from the previous dependency set; whichever change lands second must regenerate it. This PR stays a draft until #1648 merges — then it will be rebased, the regenerated (trimmed) lockfile committed here, and marked ready for review.Checklist
CONTRIBUTING.mdregarding the scope of PRs.CHANGELOG.md, which concisely describes the change. (Not applicable: test-fixture-only change with no user-facing behavior — no entry added.)