Refactor def eq handling #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Seperate handling of 'def' and '=' into distinct blocks. - Changes applied consistently across all C source files containing builtin_var.
|
First of all, fantastic book! Educational and fun read! :) I'm wondering whether the amount of code duplication that this change introduces is acceptable, considering that the main goal of the code isn't to be super performant, but rather to be understandable and succinct. Perhaps the original code is better in that regard. Would love to hear thoughts on balancing optimisations vs conciseness in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: move 'def' and '=' handling to outside of the for loop in builtin_var