fix(spawn): pin Git Bash for Windows Terminal - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cygpath -wwt.exeandwt, avoiding Windows PATH resolution of barebashRoot cause
The Windows launcher used
wt.exe new-tab bash -l .... Becausewt.exeis native, barebashis resolved through the Windows PATH and can select the WSLbash.exeshim. WSL Bash then cannot open the Git Bash/Windows-style boot-script path.Impact
Windows users with Git Bash and WSL installed can use the default
spawn.shWindows Terminal path without a custom--terminalworkaround. Custom terminal templates are unchanged.Validation
bats tests/test_spawn.bats --filter 'Windows Terminal receives'— passbash -n scripts/spawn.sh— passgit diff --check— passbats tests/test_spawn.bats— 73 pass, 2 pre-existing Windows-local failuresspawn: errors when $TMUX is set but tmux is not on PATHspawn: refuses when the name is held by another live session4bcfde9)Closes #39