You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cargo test --manifest-path apps/desktop/src-tauri/Cargo.toml (31 passed)
Stack
Depends on #183, #182, #181, and #180. This completes the first shared-host assembly slice; desktop moves only after the packaging ADR proves its runtime boundary.
RuntimeHost is the right boundary, and the split between host-owned services (provider, tools, permissions, hooks, sandbox, auto-mode, plugin dirs) and per-turn inputs is clean. Exposing only an explicit mode override — rather than letting callers re-supply arbitrary policy per turn — is what stops #181's invariant from being re-openable one caller at a time.
What I checked
CLI REPL, headless, LSP, and both VS Code entry points are all migrated, so there is no remaining path that hand-assembles a runtime. That matters more than the refactor itself: the previous bug class was "one client assembles it differently".
The headless SIGINT/SIGTERM fix deserves calling out. Headless already constructed an AbortSignal and simply never passed it to the runtime, so Ctrl+C set up a cancellation that could not cancel anything. One-line class of bug, complete loss of function — and exactly the kind of thing a shared host assembly makes structurally harder to reintroduce.
Validation: CI green; full suite green locally at the stack tip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeHostboundary that owns provider, tools, permissions, hooks, sandbox, auto-mode, and plugin directoriesValidation
pnpm docs:checkpnpm lint(3 pre-existing warnings, 0 errors)pnpm format:checkpnpm typecheckpnpm testpnpm buildcargo check --manifest-path apps/desktop/src-tauri/Cargo.tomlcargo test --manifest-path apps/desktop/src-tauri/Cargo.toml(31 passed)Stack
Depends on #183, #182, #181, and #180. This completes the first shared-host assembly slice; desktop moves only after the packaging ADR proves its runtime boundary.