Fix tactile sensor port auto-detection#72
Merged
Conversation
… wrong device After connect() succeeds, validate with get_tactile_configuration() to confirm the sensor actually responded. If not, disconnect and fall through to VID-based auto-detect. Also remove the guard that skipped auto-detect when the VID match was the same port as the configured one. Simplify example_tactile.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_tactile_configuration()afterconnect()succeeds, so a wrong-device port (e.g./dev/ttyACM1when the sensor is on/dev/ttyACM0) falls through to VID-based auto-detect instead of silently appearing "connected"chosen != self.config.sensor_portguard on the auto-detect path — if the configured port failed validation, a VID match on the same port should still be retriedexample_tactile.pyto a singlemainfunctionTest plan
uv run python scripts/example_tactile.py— auto-detects correct port and streams forcesuv run python scripts/test_sensors.py orca_core/models/v2/orcahand-touch— explicit port still worksuv run pytest tests/— 210 tests pass🤖 Generated with Claude Code