Skip to content

fix: Fix occasionally incorrect unit in some tables [2/4] #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassila merged 1 commit into from
Aug 26, 2025
Merged

fix: Fix occasionally incorrect unit in some tables [2/4] #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Sources/Benchmark/BenchmarkResult.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,6 @@ public struct BenchmarkResult: Codable, Comparable, Equatable {
_ rhs: Int,
_ percentile: Self.Percentile,
_ thresholds: BenchmarkThresholds,
_ scalingFactor: Statistics.Units,
_ thresholdResults: inout ThresholdDeviations,
_ name: String = "unknown name",
_ target: String = "unknown target"
Expand All @@ -514,7 +513,7 @@ public struct BenchmarkResult: Codable, Comparable, Equatable {
difference: Int(Statistics.roundToDecimalplaces(relativeDifference, 1)),
differenceThreshold: Int(threshold),
relative: true,
units: scalingFactor
units: Statistics.Units(timeUnits)
)
if relativeDifference > threshold {
thresholdResults.regressions.append(deviation)
Expand All @@ -534,7 +533,7 @@ public struct BenchmarkResult: Codable, Comparable, Equatable {
difference: normalize(absoluteDifference),
differenceThreshold: normalize(threshold),
relative: false,
units: scalingFactor
units: Statistics.Units(timeUnits)
)

if absoluteDifference > threshold {
Expand Down Expand Up @@ -568,7 +567,6 @@ public struct BenchmarkResult: Codable, Comparable, Equatable {
rhsPercentiles[percentile],
Self.Percentile(rawValue: percentile)!,
thresholds,
lhs.statistics.units(),
&thresholdResults,
name,
target
Expand All @@ -594,7 +592,6 @@ public struct BenchmarkResult: Codable, Comparable, Equatable {
p90Threshold,
.p90,
thresholds,
statistics.units(),
&thresholdResults,
name,
target
Expand Down
Loading