feat: Add environment variable forwarding through plugin sandbox #340
+415
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--env NAME=VALUEargument to forward environment variables through the Swift Package Manager plugin sandboxwithEnvironmenthelper functions to build environment arrays forposix_spawnthat include extra variablesposix_spawncalls in bothBenchmarkCommandPluginandBenchmarkToolto use the custom environmentThis is needed because SPM plugins run in a sandboxed environment that strips
DYLD_*and other environment variables. The new--envargument allows users to explicitly pass through environment variables that would otherwise be lost.Why this is needed
The issue is the SPM plugin sandbox. Here's the chain:
By the time
BenchmarkCommandPluginruns, Apple's sandbox has already removedDYLD_*variables fromenvironfor security reasons. The--envflag works around this by letting users explicitly specify variables as command-line arguments, which bypass the environment stripping.Test plan
--env VAR=valuepasses through to benchmark subprocesses--envcontinues to workTest results
EnvironmentForwardingTests.swiftverify the environment building logic--envcorrectly passes variables to subprocesses viaposix_spawn--envto confirm no breaking changes🤖 Generated with Claude Code