Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create US-SAM #580

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Create US-SAM #580

merged 4 commits into from
Jul 30, 2024

Conversation

siwhitehouse
Copy link
Contributor

New list for the System for Award Management that maintains Unique Entity Identifiers

New list for the System for Award Management that maintains Unique Entity Identifiers
@siwhitehouse
Copy link
Contributor Author

@kd-ods could you review this PR for US-SAM, please? I've added @HollyODSC to observe the process.

Copy link
Contributor

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as the 2 specific items of feedback, the entire entry needs to have a .json file extension added and it needs to sit in the lists/us directory.

So at the top of the 'Files changed' tab, it should read 'lists/us/us-sam.json'.

lists/US-SAM Outdated Show resolved Hide resolved
lists/US-SAM Outdated
},
"url": "https://sam.gov/content/entity-registration",
"description": {
"en": "The System for Award Management (SAM) of U.S. General Services Administration (GSA). The System for Award Management website (SAM.gov) is an official website of the U.S. Government that allows users to register to do business with the U.S. Government\nTo do so, and to use other functionality such as full search, requires a login through the US government's Login.gov service. https://www.login.gov/policy/rules-of-use/ states that The Login.gov service is operated within the United States, but is accessible globally for public use. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description needs to be edited to focus on the unique entity identifier issued by SAM. So something like:

"The System for Award Management (SAM) is....blah blah blah

SAM.gov issues the Unique Entity ID which is used across the federal government. (Previously a DUNS Number was used...blah blah"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some edits to the description as per your suggestions.

@siwhitehouse siwhitehouse requested a review from kd-ods July 28, 2024 15:17
Copy link
Contributor

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Will merge and update the website now.

@kd-ods kd-ods merged commit 77a7fa4 into main Jul 30, 2024
4 of 6 checks passed
@kd-ods kd-ods deleted the siwhitehouse-us-sam branch July 30, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants