Refactor the list of servers + add us-east1 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtsisyk
force-pushed
the
refactoring
branch
from
11ee626 to
5e92585
Compare
biodranik
approved these changes
Sep 25, 2024
src/servers.ts
Outdated
| 220816, 220912, 221029, 221119, 221216, 230121, 230210, 230227, 230329, 230503, 230602, 230710, 230814, 230920, | ||
| 231113, 231213, 240105, 240202, 240228, 240326, 240429, 240528, 240613, 240702, 240723, 240810, 240904, | ||
| ], | ||
| dataVersions: 99999, |
There was a problem hiding this comment.
Добавил. Уточню, что на planet не хватает каких-то совсем древних версий от 2021 года, но я посчитал возможным на это забить ради упрощения.
test/servers.test.ts
Outdated
| @@ -17,7 +17,7 @@ describe('X-OM-DataVersion', () => { | |||
| const server = SERVER.fi1; | |||
| let req = new Request(URL, { | |||
| headers: { | |||
| 'X-OM-DataVersion': String(server.dataVersions[0]), | |||
| 'X-OM-DataVersion': String(DATA_VERSIONS[DATA_VERSIONS.length - 1]), | |||
There was a problem hiding this comment.
Обновил. В оригинальном тесте проверялась не последняя версия, а самая ранняя на сервере. Но как будто сам тест тестирует не это.
rtsisyk
force-pushed
the
refactoring
branch
from
5e92585 to
cb21b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.