-
-
Notifications
You must be signed in to change notification settings - Fork 264
feat(tracing): migrate logging to tracing #1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
+ Coverage 43.40% 43.69% +0.30%
==========================================
Files 23 23
Lines 2247 2232 -15
==========================================
Hits 975 975
+ Misses 1272 1257 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
10 seconds ago I was happy that my GitHub notifications were clear and then Shingo comes in with a crazy PR!!!!! +0 additions -0 deletions though. Love it. LGTM |
|
planning to do any progress on this soon? (added to 2.12.0 milestone) |
Yeah, I'm planning to open a PR later this week. |
|
yup, 2.12.0 will happen in 2026 :) |
|
Sorry for the delay. I'll start working on this PR today. |
|
No worries at all! |
5bb0f7b to
f6b930d
Compare
f6b930d to
b273940
Compare
b273940 to
b1e9f80
Compare
|
This is ready for review now @orhun . I consider this a first draft, and there are likely areas open for discussion. When you have time, I'd really appreciate your thoughts and feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO:
- Replace all ASCII color codes with
owo_colors. - Consider how to handle Windows and non-TTY environments (this may also have been an issue in the previous implementation).
b2940eb to
71cc1a4
Compare
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
…ntics Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
75b4d8d to
b53b100
Compare
Description
This PR migrates the logging implementation from
env_loggertotracing.The migration preserves the existing log format while extending it to include span information, enabling more structured and contextual logging without changing the default user experience.
Motivation and Context
This change is motivated by the following discussion and issues:
env_loggertotracing+tracing-subscriber#1268The goal is to modernize
git-cliff's logging infrastructure by adoptingtracing, while maintaining backward compatibility and avoiding unnecessary complexity in the core crate.What Has Changed
git-cliff-corenow depends ontracingbehind a feature flag.logoutput is produced.tracing-based implementation usingtracing-indicatif.tracing, implementing such behavior cleanly would require API changes outside ofgit-cliff-core.How Has This Been Tested?
Screenshots / Logs (if applicable)
N/A
Types of Changes
Checklist: