Skip to content

Azure devops commit serialization #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taladar wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

Azure devops commit serialization #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c8d3e
fix(context): Add missing serialization of Commit azure_devops field
taladar Dec 17, 2025
d5ae4a0
fix(release): Fix azureDevops/azure_devops serialization/deserializat…
taladar Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions git-cliff-core/src/commit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,8 @@ impl Serialize for Commit<'_> {
commit.serialize_field("gitea", &self.gitea)?;
#[cfg(feature = "bitbucket")]
commit.serialize_field("bitbucket", &self.bitbucket)?;
#[cfg(feature = "azure_devops")]
commit.serialize_field("azure_devops", &self.azure_devops)?;
Copy link
Contributor

@ognis1205 ognis1205 Dec 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Camel Case in JSON is the established convention. Can we change this to azureDevops instead?

This looks good to me.

if let Some(remote) = &self.remote {
commit.serialize_field("remote", remote)?;
}
Expand Down
1 change: 1 addition & 0 deletions git-cliff-core/src/release.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ pub struct Release<'a> {
pub bitbucket: RemoteReleaseMetadata,
/// Contributors.
#[cfg(feature = "azure_devops")]
#[serde(rename = "azure_devops")]
Copy link
Contributor

@ognis1205 ognis1205 Dec 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this change?

This looks good to me.

pub azure_devops: RemoteReleaseMetadata,
}

Expand Down
Loading