-
-
Notifications
You must be signed in to change notification settings - Fork 264
feat(remote): add offline flag #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1321 +/- ##
==========================================
+ Coverage 43.43% 43.47% +0.04%
==========================================
Files 23 23
Lines 2245 2250 +5
==========================================
+ Hits 975 978 +3
- Misses 1270 1272 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orhun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Also we need to update the documentation/website about this new flag :)
b2d0f61 to
0985ab0
Compare
Thank you for your patience here! I've added your suggested changes and a small section to the website. I was also looking for a way to test it, but in the way the |
|
Check out the test fixtures here. I believe we can copy one of the GitHub integration ones, run it with |
Description
Add a
--offlineflag to enable running e.g.--bumped-versionwithout contacting any external services, even if they are configured. Closes #1095.Motivation and Context
See #1095 .
How Has This Been Tested?
Local unit and integration tests, including building and running the binary in my local repo.
NOTE! Three unrelated tests were failing when I started my implementation:
Screenshots / Logs (if applicable)
Types of Changes
Checklist: